-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watcher: send objects only if they have been changed #452
Merged
denis-tingaikin
merged 2 commits into
networkservicemesh:main
from
glazychev-art:watcher_fix
Sep 15, 2023
Merged
watcher: send objects only if they have been changed #452
denis-tingaikin
merged 2 commits into
networkservicemesh:main
from
glazychev-art:watcher_fix
Sep 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k@main PR link: networkservicemesh/sdk#1505 Commit: f96fdf6 Author: Network Service Mesh Bot Date: 2023-08-28 11:31:19 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505) PR link: networkservicemesh/api#165 Commit: c4a3ece Author: Nikita Skrynnik Date: 2023-08-22 21:51:24 +0700 Message: - Fix Connection Selector (networkservicemesh#165) * fix selector * minor check * fix golang linter * add tests for MatchesMonitorScopeSelector * fix linter issue --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we cover changes by unit test?
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
watcher_fix
branch
from
September 15, 2023 07:19
a949ae0
to
8734ad7
Compare
denis-tingaikin
approved these changes
Sep 15, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Sep 15, 2023
…k-k8s@main PR link: networkservicemesh/sdk-k8s#452 Commit: 14a8d4d Author: Denis Tingaikin Date: 2023-09-15 12:22:02 +0300 Message: - Merge pull request #452 from glazychev-art/watcher_fix Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-k8s
that referenced
this pull request
Sep 15, 2023
…k-k8s@main PR link: networkservicemesh/sdk-k8s#452 Commit: 14a8d4d Author: Denis Tingaikin Date: 2023-09-15 12:22:02 +0300 Message: - Merge pull request #452 from glazychev-art/watcher_fix Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-sriov
that referenced
this pull request
Sep 15, 2023
…k-k8s@main PR link: networkservicemesh/sdk-k8s#452 Commit: 14a8d4d Author: Denis Tingaikin Date: 2023-09-15 12:22:02 +0300 Message: - Merge pull request #452 from glazychev-art/watcher_fix Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-exclude-prefixes-k8s
that referenced
this pull request
Sep 15, 2023
…k-k8s@main PR link: networkservicemesh/sdk-k8s#452 Commit: 14a8d4d Author: Denis Tingaikin Date: 2023-09-15 12:22:02 +0300 Message: - Merge pull request #452 from glazychev-art/watcher_fix Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Sep 15, 2023
…k-k8s@main PR link: networkservicemesh/sdk-k8s#452 Commit: 14a8d4d Author: Denis Tingaikin Date: 2023-09-15 12:22:02 +0300 Message: - Merge pull request #452 from glazychev-art/watcher_fix Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-ovs
that referenced
this pull request
Sep 15, 2023
…k-k8s@main PR link: networkservicemesh/sdk-k8s#452 Commit: 14a8d4d Author: Denis Tingaikin Date: 2023-09-15 12:22:02 +0300 Message: - Merge pull request #452 from glazychev-art/watcher_fix Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-supplier-k8s
that referenced
this pull request
Sep 15, 2023
…k-k8s@main PR link: networkservicemesh/sdk-k8s#452 Commit: 14a8d4d Author: Denis Tingaikin Date: 2023-09-15 12:22:02 +0300 Message: - Merge pull request #452 from glazychev-art/watcher_fix Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: networkservicemesh/deployments-k8s#9210