Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watcher: send objects only if they have been changed #452

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Sep 14, 2023

…k@main

PR link: networkservicemesh/sdk#1505

Commit: f96fdf6
Author: Network Service Mesh Bot
Date: 2023-08-28 11:31:19 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1505)
PR link: networkservicemesh/api#165

Commit: c4a3ece
Author: Nikita Skrynnik
Date: 2023-08-22 21:51:24 +0700
Message:
    - Fix Connection Selector (networkservicemesh#165)
* fix selector

* minor check

* fix golang linter

* add tests for MatchesMonitorScopeSelector

* fix linter issue

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we cover changes by unit test?

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit 14a8d4d into networkservicemesh:main Sep 15, 2023
11 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Sep 15, 2023
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#452

Commit: 14a8d4d
Author: Denis Tingaikin
Date: 2023-09-15 12:22:02 +0300
Message:
  - Merge pull request #452 from glazychev-art/watcher_fix
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-k8s that referenced this pull request Sep 15, 2023
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#452

Commit: 14a8d4d
Author: Denis Tingaikin
Date: 2023-09-15 12:22:02 +0300
Message:
  - Merge pull request #452 from glazychev-art/watcher_fix
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-sriov that referenced this pull request Sep 15, 2023
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#452

Commit: 14a8d4d
Author: Denis Tingaikin
Date: 2023-09-15 12:22:02 +0300
Message:
  - Merge pull request #452 from glazychev-art/watcher_fix
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-exclude-prefixes-k8s that referenced this pull request Sep 15, 2023
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#452

Commit: 14a8d4d
Author: Denis Tingaikin
Date: 2023-09-15 12:22:02 +0300
Message:
  - Merge pull request #452 from glazychev-art/watcher_fix
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-vpp that referenced this pull request Sep 15, 2023
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#452

Commit: 14a8d4d
Author: Denis Tingaikin
Date: 2023-09-15 12:22:02 +0300
Message:
  - Merge pull request #452 from glazychev-art/watcher_fix
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-ovs that referenced this pull request Sep 15, 2023
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#452

Commit: 14a8d4d
Author: Denis Tingaikin
Date: 2023-09-15 12:22:02 +0300
Message:
  - Merge pull request #452 from glazychev-art/watcher_fix
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-supplier-k8s that referenced this pull request Sep 15, 2023
…k-k8s@main

PR link: networkservicemesh/sdk-k8s#452

Commit: 14a8d4d
Author: Denis Tingaikin
Date: 2023-09-15 12:22:02 +0300
Message:
  - Merge pull request #452 from glazychev-art/watcher_fix
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants