Fix for Policy Base Routing failure; Possible table ID collision. #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New solution based on this hint: #583 (comment) |
LionelJouin
reviewed
Jun 13, 2023
pkg/kernel/networkservice/connectioncontextkernel/ipcontext/iprule/common.go
Show resolved
Hide resolved
denis-tingaikin
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
LGTM
@ljkiraly Could you apply fixes for the comment https://github.com/networkservicemesh/sdk-kernel/pull/588/files#r1227954152?
LionelJouin
reviewed
Jun 14, 2023
| ps[tableID] = policy | ||
| tableIDs.Store(connID, ps) | ||
| // release the lock | ||
| nsRTableNextIDToConnID.Delete(nsrtid) |
There was a problem hiding this comment.
Suggested change
| nsRTableNextIDToConnID.Delete(nsrtid) |
This could be removed
Related issue: networkservicemesh/deployments-k8s/issues/9119 Added a mechanism to protect table ID selection from parallel runs. Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
LionelJouin
approved these changes
Jun 14, 2023
nsmbot
pushed a commit
to networkservicemesh/sdk-sriov
that referenced
this pull request
Jun 15, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#588 Commit: 61983f6 Author: Denis Tingaikin Date: 2023-06-16 02:43:39 +0300 Message: - Merge pull request #588 from Nordix/fix-sync-pbr Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Jun 15, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#588 Commit: 61983f6 Author: Denis Tingaikin Date: 2023-06-16 02:43:39 +0300 Message: - Merge pull request #588 from Nordix/fix-sync-pbr Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-l7-proxy
that referenced
this pull request
Jun 15, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#588 Commit: 61983f6 Author: Denis Tingaikin Date: 2023-06-16 02:43:39 +0300 Message: - Merge pull request #588 from Nordix/fix-sync-pbr Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: networkservicemesh/deployments-k8s/issues/9119
Added a mechanism to protect table ID selection from parallel runs.