Add iommu groups and drivers info to resource pool #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Semenov <sergey.semenov@xored.com>
Signed-off-by: Sergey Semenov <sergey.semenov@xored.com>
Signed-off-by: Sergey Semenov <sergey.semenov@xored.com>
Bolodya1997
reviewed
Jul 30, 2020
|
|
||
| return nil | ||
| } | ||
|
|
||
| // PhysicalFunction contains information about physical function | ||
| type PhysicalFunction struct { |
There was a problem hiding this comment.
It looks like PhysicalFunction duplicates all VirtualFunction fields, so please consider using extension:
type PhysicalFunction struct {
TargetPCIAddress string
Capability string
VirtualFunctionsCapacity int
VirtualFunctions map[*VirtualFunction]VirtualFunctionState
VirtualFunction
}
There was a problem hiding this comment.
I wonder will it be a little confusing
There was a problem hiding this comment.
Initialization example:
physfun := &PhysicalFunction{
VirtualFunction: VirtualFunction{
PCIAddress: pfPciAddr,
BoundDriver: KernelDriver, // Kernel driver is bound by default
KernelDriverName: pfKernelDriverName,
IommuGroup: pfIommuGroup,
NetInterfaceName: pfIfaceNames[0],
},
TargetPCIAddress: device.Target.PCIAddress,
Capability: device.Capability,
VirtualFunctionsCapacity: vfCapacity,
VirtualFunctions: map[*VirtualFunction]VirtualFunctionState{},
}There was a problem hiding this comment.
What about having something like that?
type NetworkFunction struct {
PCIAddress string
BoundDriver DriverType
KernelDriverName string
IommuGroup int
NetInterfaceName string
}
type VirtualFunction NetworkFunction
type PhysicalFunction struct {
NetworkFunction
other fields...
}
Bolodya1997
reviewed
Jul 30, 2020
pkg/sriov/types.go
Outdated
| ) | ||
|
|
||
| // NetResourcePool provides contains information about net devices | ||
| type NetResourcePool struct { | ||
| HostName string | ||
| PhysicalFunctions []*PhysicalFunction | ||
| IommuGroups map[int]DriverType | ||
| sriovProvider utils.SriovProvider |
There was a problem hiding this comment.
Do we need utils.SriovProvider as a part of NetResourcePool? I believe it should be only used in InitResourcePool and so should be passed in there as an argument.
Bolodya1997
reviewed
Jul 30, 2020
pkg/sriov/types.go
Outdated
| HostName: config.HostName, | ||
| PhysicalFunctions: nil, | ||
| IommuGroups: map[int]DriverType{}, | ||
| sriovProvider: utils.NewSriovProvider(pciDevicesPath, pciDriversPath, iommuGroupsPath), |
There was a problem hiding this comment.
I believe such things make testing difficult. Let it be passed to the InitResourcePool as an argument?
Signed-off-by: Sergey Semenov <sergey.semenov@xored.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.