Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added: config support #3

Merged
merged 10 commits into from
Jun 23, 2020
Merged

Added: config support #3

merged 10 commits into from
Jun 23, 2020

Conversation

valeriy-simakov
Copy link
Contributor

@valeriy-simakov valeriy-simakov commented Jun 17, 2020 •
edited
Loading

Reading a configuration file with test
#5

@valeriy-simakov
Added: config support
d5ff90e 
Signed-off-by: Valeriy Simakov <simakov.valeriy@gmail.com>
@valeriy-simakov
Fixed: yamlint fail
64fe048 
Signed-off-by: Valeriy Simakov <simakov.valeriy@gmail.com>
haiodo
haiodo reviewed Jun 18, 2020
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
haiodo
haiodo reviewed Jun 18, 2020
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
@valeriy-simakov
Changed: endpoint config
370acc8 
Signed-off-by: Valeriy Simakov <simakov.valeriy@gmail.com>
denis-tingaikin
denis-tingaikin requested changes Jun 19, 2020
View reviewed changes
pkg/config/config_test.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
haiodo
haiodo reviewed Jun 19, 2020
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
@valeriy-simakov
Changed: config structs
d496645 
Signed-off-by: Valeriy Simakov <simakov.valeriy@gmail.com>
denis-tingaikin
denis-tingaikin requested changes Jun 22, 2020
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config_test.go Outdated Show resolved Hide resolved
@valeriy-simakov
Changed: rid 'Config'
fa7e39b 
Signed-off-by: Valeriy Simakov <simakov.valeriy@gmail.com>
@valeriy-simakov
Changed: license correction
5ce3ea4 
Signed-off-by: Valeriy Simakov <simakov.valeriy@gmail.com>
denis-tingaikin
denis-tingaikin reviewed Jun 22, 2020
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
denis-tingaikin
denis-tingaikin approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this PR looks good, added comments for a few minor nits.

@valeriy-simakov
Changed: minor changes
5d5b716 
Signed-off-by: Valeriy Simakov <simakov.valeriy@gmail.com>
@valeriy-simakov valeriy-simakov marked this pull request as ready for review June 22, 2020 15:58
haiodo
haiodo reviewed Jun 23, 2020
View reviewed changes
pkg/config/config.yml Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
@valeriy-simakov
Changed: folders struct
e349f0f 
Signed-off-by: Valeriy Simakov <simakov.valeriy@gmail.com>
@haiodo haiodo merged commit b2c0c3b into networkservicemesh:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo left review comments

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@valeriy-simakov @haiodo @denis-tingaikin