skip kernel driver bind check #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
pperiyasamy
requested review from
Bolodya1997,
denis-tingaikin and
edwarnicke
|
/cc @JanScheurich |
|
@edwarnicke @denis-tingaikin Now I see v1.1.1 release is done on this repo, can we get this PR merged ? |
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Dec 15, 2021
…k-sriov@main PR link: networkservicemesh/sdk-sriov#322 Commit: 0e2b02a Author: Ed Warnicke Date: 2021-12-15 09:02:58 -0600 Message: - Merge pull request #322 from Nordix/skip-driver-check Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-sriov
that referenced
this pull request
Dec 15, 2021
…k-sriov@main PR link: networkservicemesh/sdk-sriov#322 Commit: 0e2b02a Author: Ed Warnicke Date: 2021-12-15 09:02:58 -0600 Message: - Merge pull request #322 from Nordix/skip-driver-check Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Dec 15, 2021
…k-sriov@main PR link: networkservicemesh/sdk-sriov#322 Commit: 0e2b02a Author: Ed Warnicke Date: 2021-12-15 09:02:58 -0600 Message: - Merge pull request #322 from Nordix/skip-driver-check Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc
that referenced
this pull request
Dec 15, 2021
…k-sriov@main PR link: networkservicemesh/sdk-sriov#322 Commit: 0e2b02a Author: Ed Warnicke Date: 2021-12-15 09:02:58 -0600 Message: - Merge pull request #322 from Nordix/skip-driver-check Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Dec 15, 2021
…k-sriov@main PR link: networkservicemesh/sdk-sriov#322 Commit: 0e2b02a Author: Ed Warnicke Date: 2021-12-15 09:02:58 -0600 Message: - Merge pull request #322 from Nordix/skip-driver-check Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Dec 15, 2021
…k-sriov@main PR link: networkservicemesh/sdk-sriov#322 Commit: 0e2b02a Author: Ed Warnicke Date: 2021-12-15 09:02:58 -0600 Message: - Merge pull request #322 from Nordix/skip-driver-check Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-ovs
that referenced
this pull request
Dec 15, 2021
…k-sriov@main PR link: networkservicemesh/sdk-sriov#322 Commit: 0e2b02a Author: Ed Warnicke Date: 2021-12-15 09:02:58 -0600 Message: - Merge pull request #322 from Nordix/skip-driver-check Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 15, 2021
Merged
|
Thanks @edwarnicke ! |
edwarnicke
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Dec 16, 2021
…k-sriov@main PR link: networkservicemesh/sdk-sriov#322 Commit: 0e2b02a Author: Ed Warnicke Date: 2021-12-15 09:02:58 -0600 Message: - Merge pull request #322 from Nordix/skip-driver-check Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a new NewPCIPool API to skip kernel driver bind check as it always checks kernel interface present on the pci device. It's no more valid for VLAN trunking scenario as interface is moved into NSE container when first NS client shows up and won't be present for subsequent NS clients.
Will update cmd-forwarder-ovs to consume NewPCIPool API once this PR is merged.
Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech