Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk#1028] Fix Timeout, Expire to handle failed Close, Unregister #1030

Merged
merged 4 commits into from
Jul 20, 2021

Conversation

Bolodya1997
Copy link

@Bolodya1997 Bolodya1997 commented Jul 19, 2021

Description

Checks if Close, Unregister succeed before stopping timeout, expire timer.

Issue link

Closes #1028

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Vladimir Popov added 2 commits July 19, 2021 20:23
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@Bolodya1997 Bolodya1997 marked this pull request as draft July 20, 2021 06:23
Vladimir Popov added 2 commits July 20, 2021 16:21
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@Bolodya1997 Bolodya1997 marked this pull request as ready for review July 20, 2021 09:46
@edwarnicke
Copy link
Member

@Bolodya1997 Is this good to go?

@Bolodya1997
Copy link
Author

@Bolodya1997 Is this good to go?

@edwarnicke Yes, please merge it if you are OK with this :)

@edwarnicke edwarnicke merged commit 0602401 into networkservicemesh:main Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout, Expire stop timer if Close, Unregister fails
4 participants