Fix next to *always* work. #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now in the event where you run a chain element outside of a chain, you will get a panic on calls to things like: next.Server(ctx).Request(...) This fixes that. Now it never panics. Signed-off-by: Ed Warnicke <hagbard@gmail.com>
fkautz
approved these changes
Feb 17, 2020
Merged
nsmbot
pushed a commit
that referenced
this pull request
Jul 7, 2021
…i@main networkservicemesh/api# networkservicemesh/api PR link: https://github.com/networkservicemesh/api/pull/ networkservicemesh/api commit message: commit 3bce416a9f33f54b11d554a65bee76e591383169 Author: Авраменко Михаил <mikhail.avramenko@xored.com> Date: Thu Jul 8 00:45:02 2021 +0700 Added fallthrough_on_empty field for match object (#106) * added fallthrough on empty field Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * re-generated proto models Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * re-generated files with correct versions of protobuf Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now in the event where you run a chain element outside of a chain, you will get a panic
on calls to things like:
next.Server(ctx).Request(...)
This fixes that. Now it never panics.