Fixes for data races in logs #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mixaster995
changed the title
log.Fields()
Mixaster995
force-pushed
the
bug/fix-data-race
branch
from
015e3fc
to
0170f05
Compare
Mixaster995
requested review from
denis-tingaikin,
glazychev-art and
Bolodya1997
and removed request for
denis-tingaikin
Mixaster995
force-pushed
the
bug/fix-data-race
branch
7 times, most recently
from
35041ec
to
3fdb382
Compare
edwarnicke
reviewed
Oct 30, 2021
| @@ -38,7 +38,7 @@ import ( | |||
| func TestCreateEndpointDuringRequest(t *testing.T) { | |||
| t.Cleanup(func() { goleak.VerifyNone(t) }) | |||
|
|
|||
| ctx, cancel := context.WithTimeout(context.Background(), time.Second*10) | |||
| ctx, cancel := context.WithTimeout(context.Background(), time.Second*5*10) | |||
There was a problem hiding this comment.
Why are we suddenly 10x-ing all of the timeouts? What are we doing that is bloating the latency by 10x?
There was a problem hiding this comment.
It seems, that enabling full logs in tests running with race flag, increases time for tests. That's not something i'm going to actually push to sdk code, some changes only have been made for testing, so i'm converted this PR to draft, until it's ready.
Mixaster995
force-pushed
the
bug/fix-data-race
branch
4 times, most recently
from
eae57ad
to
eb9653e
Compare
Mixaster995
changed the title
log.Fields()
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Mixaster995
force-pushed
the
bug/fix-data-race
branch
6 times, most recently
from
dfe7b40
to
eaceefe
Compare
Mixaster995
force-pushed
the
bug/fix-data-race
branch
from
eaceefe
to
4426378
Compare
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Mixaster995
force-pushed
the
bug/fix-data-race
branch
from
4426378
to
37803f5
Compare
|
@denis-tingaikin removed all unrelated changes from PR |
denis-tingaikin
approved these changes
Nov 2, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1125 Commit: 0a90a22 Author: Авраменко Михаил Date: 2021-11-02 12:54:45 +0700 Message: - Fixes for data races in logs (#1125) * added logging infrustructure in tests to catch races Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * added set log options to registry chains Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed context in heal to prevent data races Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1125 Commit: 0a90a22 Author: Авраменко Михаил Date: 2021-11-02 12:54:45 +0700 Message: - Fixes for data races in logs (#1125) * added logging infrustructure in tests to catch races Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * added set log options to registry chains Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed context in heal to prevent data races Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1125 Commit: 0a90a22 Author: Авраменко Михаил Date: 2021-11-02 12:54:45 +0700 Message: - Fixes for data races in logs (#1125) * added logging infrustructure in tests to catch races Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * added set log options to registry chains Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed context in heal to prevent data races Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1125 Commit: 0a90a22 Author: Авраменко Михаил Date: 2021-11-02 12:54:45 +0700 Message: - Fixes for data races in logs (#1125) * added logging infrustructure in tests to catch races Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * added set log options to registry chains Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed context in heal to prevent data races Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1125 Commit: 0a90a22 Author: Авраменко Михаил Date: 2021-11-02 12:54:45 +0700 Message: - Fixes for data races in logs (#1125) * added logging infrustructure in tests to catch races Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * added set log options to registry chains Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed context in heal to prevent data races Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1125 Commit: 0a90a22 Author: Авраменко Михаил Date: 2021-11-02 12:54:45 +0700 Message: - Fixes for data races in logs (#1125) * added logging infrustructure in tests to catch races Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * added set log options to registry chains Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed context in heal to prevent data races Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1125 Commit: 0a90a22 Author: Авраменко Михаил Date: 2021-11-02 12:54:45 +0700 Message: - Fixes for data races in logs (#1125) * added logging infrustructure in tests to catch races Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * added set log options to registry chains Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed context in heal to prevent data races Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Nov 2, 2021
…k@main PR link: networkservicemesh/sdk#1125 Commit: 0a90a22 Author: Авраменко Михаил Date: 2021-11-02 12:54:45 +0700 Message: - Fixes for data races in logs (#1125) * added logging infrustructure in tests to catch races Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * added set log options to registry chains Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * changed context in heal to prevent data races Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikhail Avramenko avramenkomihail15@gmail.com
Description
Refactored usage of log fields to prevent data races
Issue link
fixes networkservicemesh/cmd-forwarder-vpp#372
How Has This Been Tested?
Types of changes