Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update discoverforwarder to latest api changes #1151

Merged

Conversation

denis-tingaikin
Copy link
Member

Signed-off-by: denis-tingaikin denis.tingajkin@xored.com

Description

Issue link

Requires for #1094
Requires for networkservicemesh/integration-k8s-kind#454

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin denis-tingaikin force-pushed the improve-discover-forwarder branch 3 times, most recently from 6cd4493 to 9c1522b Compare November 10, 2021 19:38
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
.golangci.yml Outdated
@@ -47,7 +47,7 @@ linters-settings:
- errors
packages-with-error-message:
# specify an error message to output when a blacklisted package is used
- errors: "Please use \"github.com/pkg/errors\" instead of \"errors\" in go imports"
- errors: "Please use \"github.com/pkg/errors\" instead of \"errors\" in go imports"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, why the extra white space here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@edwarnicke edwarnicke merged commit 2272de7 into networkservicemesh:main Nov 10, 2021
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Nov 10, 2021
…k@main

PR link: networkservicemesh/sdk#1151

Commit: 2272de7
Author: Denis Tingaikin
Date: 2021-11-10 23:03:17 +0300
Message:
  - feat: Update discoverforwarder to latest api changes (#1151)
* update discoverforwarder to latest api changes

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yamllinter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Nov 10, 2021
…k@main

PR link: networkservicemesh/sdk#1151

Commit: 2272de7
Author: Denis Tingaikin
Date: 2021-11-10 23:03:17 +0300
Message:
  - feat: Update discoverforwarder to latest api changes (#1151)
* update discoverforwarder to latest api changes

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yamllinter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Nov 10, 2021
…k@main

PR link: networkservicemesh/sdk#1151

Commit: 2272de7
Author: Denis Tingaikin
Date: 2021-11-10 23:03:17 +0300
Message:
  - feat: Update discoverforwarder to latest api changes (#1151)
* update discoverforwarder to latest api changes

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yamllinter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Nov 10, 2021
…k@main

PR link: networkservicemesh/sdk#1151

Commit: 2272de7
Author: Denis Tingaikin
Date: 2021-11-10 23:03:17 +0300
Message:
  - feat: Update discoverforwarder to latest api changes (#1151)
* update discoverforwarder to latest api changes

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yamllinter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Nov 10, 2021
…k@main

PR link: networkservicemesh/sdk#1151

Commit: 2272de7
Author: Denis Tingaikin
Date: 2021-11-10 23:03:17 +0300
Message:
  - feat: Update discoverforwarder to latest api changes (#1151)
* update discoverforwarder to latest api changes

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yamllinter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Nov 10, 2021
…k@main

PR link: networkservicemesh/sdk#1151

Commit: 2272de7
Author: Denis Tingaikin
Date: 2021-11-10 23:03:17 +0300
Message:
  - feat: Update discoverforwarder to latest api changes (#1151)
* update discoverforwarder to latest api changes

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yamllinter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Nov 10, 2021
…k@main

PR link: networkservicemesh/sdk#1151

Commit: 2272de7
Author: Denis Tingaikin
Date: 2021-11-10 23:03:17 +0300
Message:
  - feat: Update discoverforwarder to latest api changes (#1151)
* update discoverforwarder to latest api changes

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yamllinter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Nov 10, 2021
…k@main

PR link: networkservicemesh/sdk#1151

Commit: 2272de7
Author: Denis Tingaikin
Date: 2021-11-10 23:03:17 +0300
Message:
  - feat: Update discoverforwarder to latest api changes (#1151)
* update discoverforwarder to latest api changes

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yamllinter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Nov 10, 2021
…k@main

PR link: networkservicemesh/sdk#1151

Commit: 2272de7
Author: Denis Tingaikin
Date: 2021-11-10 23:03:17 +0300
Message:
  - feat: Update discoverforwarder to latest api changes (#1151)
* update discoverforwarder to latest api changes

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix yamllinter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants