Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated golangci-lint version, fixed linter errors #1208

Merged

Conversation

sol-0
Copy link
Contributor

@sol-0 sol-0 commented Dec 29, 2021

Description

Updated golangci-lint to 1.42.1 and fixed linter errors

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Oleg Solodkov oleg.solodkov@xored.com

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
@sol-0 sol-0 force-pushed the feature-golangci-lint-1-42-1 branch from c8e7bc7 to 33ac895 Compare December 29, 2021 17:12
Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>
@sol-0 sol-0 closed this Dec 29, 2021
@sol-0 sol-0 reopened this Dec 29, 2021
@denis-tingaikin
Copy link
Member

@sol-0 Is this PR ready to merge?

@sol-0 sol-0 marked this pull request as ready for review December 30, 2021 09:15
@sol-0
Copy link
Contributor Author

sol-0 commented Dec 30, 2021

@denis-tingaikin , yes, it's ready.

@denis-tingaikin denis-tingaikin merged commit fe9702d into networkservicemesh:main Jan 10, 2022
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jan 10, 2022
…k@main

PR link: networkservicemesh/sdk#1208

Commit: fe9702d
Author: Sol-0
Date: 2022-01-10 16:09:42 +0700
Message:
  - Updated golangci-lint version, fixed linter errors (#1208)
* Updated golangci-lint version, fixed linter errors

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Changed golangci-lint timeout to 2 mins

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Reverted golangci-lint timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jan 10, 2022
…k@main

PR link: networkservicemesh/sdk#1208

Commit: fe9702d
Author: Sol-0
Date: 2022-01-10 16:09:42 +0700
Message:
  - Updated golangci-lint version, fixed linter errors (#1208)
* Updated golangci-lint version, fixed linter errors

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Changed golangci-lint timeout to 2 mins

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Reverted golangci-lint timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jan 10, 2022
…k@main

PR link: networkservicemesh/sdk#1208

Commit: fe9702d
Author: Sol-0
Date: 2022-01-10 16:09:42 +0700
Message:
  - Updated golangci-lint version, fixed linter errors (#1208)
* Updated golangci-lint version, fixed linter errors

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Changed golangci-lint timeout to 2 mins

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Reverted golangci-lint timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jan 10, 2022
…k@main

PR link: networkservicemesh/sdk#1208

Commit: fe9702d
Author: Sol-0
Date: 2022-01-10 16:09:42 +0700
Message:
  - Updated golangci-lint version, fixed linter errors (#1208)
* Updated golangci-lint version, fixed linter errors

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Changed golangci-lint timeout to 2 mins

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Reverted golangci-lint timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jan 10, 2022
…k@main

PR link: networkservicemesh/sdk#1208

Commit: fe9702d
Author: Sol-0
Date: 2022-01-10 16:09:42 +0700
Message:
  - Updated golangci-lint version, fixed linter errors (#1208)
* Updated golangci-lint version, fixed linter errors

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Changed golangci-lint timeout to 2 mins

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Reverted golangci-lint timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jan 10, 2022
…k@main

PR link: networkservicemesh/sdk#1208

Commit: fe9702d
Author: Sol-0
Date: 2022-01-10 16:09:42 +0700
Message:
  - Updated golangci-lint version, fixed linter errors (#1208)
* Updated golangci-lint version, fixed linter errors

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Changed golangci-lint timeout to 2 mins

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Reverted golangci-lint timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jan 10, 2022
…k@main

PR link: networkservicemesh/sdk#1208

Commit: fe9702d
Author: Sol-0
Date: 2022-01-10 16:09:42 +0700
Message:
  - Updated golangci-lint version, fixed linter errors (#1208)
* Updated golangci-lint version, fixed linter errors

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Changed golangci-lint timeout to 2 mins

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Reverted golangci-lint timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jan 10, 2022
…k@main

PR link: networkservicemesh/sdk#1208

Commit: fe9702d
Author: Sol-0
Date: 2022-01-10 16:09:42 +0700
Message:
  - Updated golangci-lint version, fixed linter errors (#1208)
* Updated golangci-lint version, fixed linter errors

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Changed golangci-lint timeout to 2 mins

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Reverted golangci-lint timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jan 10, 2022
…k@main

PR link: networkservicemesh/sdk#1208

Commit: fe9702d
Author: Sol-0
Date: 2022-01-10 16:09:42 +0700
Message:
  - Updated golangci-lint version, fixed linter errors (#1208)
* Updated golangci-lint version, fixed linter errors

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Changed golangci-lint timeout to 2 mins

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Reverted golangci-lint timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jan 10, 2022
…k@main

PR link: networkservicemesh/sdk#1208

Commit: fe9702d
Author: Sol-0
Date: 2022-01-10 16:09:42 +0700
Message:
  - Updated golangci-lint version, fixed linter errors (#1208)
* Updated golangci-lint version, fixed linter errors

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Changed golangci-lint timeout to 2 mins

Signed-off-by: Oleg Solodkov <oleg.solodkov@xored.com>

* Reverted golangci-lint timeout

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants