Initial rework pkg/registry to use begin pattern
#1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
force-pushed
the
rework-registry-begin
branch
3 times, most recently
from
b8e4189
to
25cb655
Compare
denis-tingaikin
changed the title
begin patternbegin pattern
denis-tingaikin
changed the title
begin patternbegin pattern
denis-tingaikin
force-pushed
the
rework-registry-begin
branch
2 times, most recently
from
9819e5e
to
2995e87
Compare
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
rework-registry-begin
branch
from
2995e87
to
2787d18
Compare
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
rework-registry-begin
branch
from
80fe020
to
b2d3939
Compare
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Jan 25, 2022
…k@main PR link: networkservicemesh/sdk#1213 Commit: 5eed3d9 Author: Denis Tingaikin Date: 2022-01-25 21:33:01 +0300 Message: - Initial rework pkg/registry to use `begin` pattern (#1213) * rework registry to use 'begin' pattern Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Jan 25, 2022
…k@main PR link: networkservicemesh/sdk#1213 Commit: 5eed3d9 Author: Denis Tingaikin Date: 2022-01-25 21:33:01 +0300 Message: - Initial rework pkg/registry to use `begin` pattern (#1213) * rework registry to use 'begin' pattern Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Jan 25, 2022
…k@main PR link: networkservicemesh/sdk#1213 Commit: 5eed3d9 Author: Denis Tingaikin Date: 2022-01-25 21:33:01 +0300 Message: - Initial rework pkg/registry to use `begin` pattern (#1213) * rework registry to use 'begin' pattern Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Jan 25, 2022
…k@main PR link: networkservicemesh/sdk#1213 Commit: 5eed3d9 Author: Denis Tingaikin Date: 2022-01-25 21:33:01 +0300 Message: - Initial rework pkg/registry to use `begin` pattern (#1213) * rework registry to use 'begin' pattern Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Jan 25, 2022
…k@main PR link: networkservicemesh/sdk#1213 Commit: 5eed3d9 Author: Denis Tingaikin Date: 2022-01-25 21:33:01 +0300 Message: - Initial rework pkg/registry to use `begin` pattern (#1213) * rework registry to use 'begin' pattern Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Jan 25, 2022
…k@main PR link: networkservicemesh/sdk#1213 Commit: 5eed3d9 Author: Denis Tingaikin Date: 2022-01-25 21:33:01 +0300 Message: - Initial rework pkg/registry to use `begin` pattern (#1213) * rework registry to use 'begin' pattern Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Jan 25, 2022
…k@main PR link: networkservicemesh/sdk#1213 Commit: 5eed3d9 Author: Denis Tingaikin Date: 2022-01-25 21:33:01 +0300 Message: - Initial rework pkg/registry to use `begin` pattern (#1213) * rework registry to use 'begin' pattern Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Jan 25, 2022
…k@main PR link: networkservicemesh/sdk#1213 Commit: 5eed3d9 Author: Denis Tingaikin Date: 2022-01-25 21:33:01 +0300 Message: - Initial rework pkg/registry to use `begin` pattern (#1213) * rework registry to use 'begin' pattern Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Jan 25, 2022
…k@main PR link: networkservicemesh/sdk#1213 Commit: 5eed3d9 Author: Denis Tingaikin Date: 2022-01-25 21:33:01 +0300 Message: - Initial rework pkg/registry to use `begin` pattern (#1213) * rework registry to use 'begin' pattern Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jan 25, 2022
This was referenced Jan 25, 2022
This was referenced Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com
Description
The main motivation of this PR is making healing for
registryas simple as we have fornetworkservice.All retry and heal logic has been moved into clientside.
To achieve this functionality has been reworked all overcomplicated chain elements like
connect,heal,expire,refreshto usebeginpattern.See at
beginpattern #1072 fornetworkservice.Issue link
Closes #1170
Closes networkservicemesh/deployments-k8s#4247
Closes networkservicemesh/deployments-k8s#3938
Closes networkservicemesh/deployments-k8s#1017
How Has This Been Tested?
Types of changes