Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qfix: Don't spawn logs if context has cancelled gracefully #1256

Merged

Conversation

denis-tingaikin
Copy link
Member

Signed-off-by: denis-tingaikin denis.tingajkin@xored.com

Description

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
Copy link
Member Author

This PR also fixes #1255 for this repo.

@edwarnicke Could you have a look?

@edwarnicke edwarnicke merged commit 320ddb6 into networkservicemesh:main Apr 5, 2022
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Apr 5, 2022
…k@main

PR link: networkservicemesh/sdk#1256

Commit: 320ddb6
Author: Denis Tingaikin
Date: 2022-04-05 19:08:22 +0300
Message:
  - qfix: Don't spawn logs if context has cancelled gracefully (#1256)
* don't spawn logs if context has cancelled gracefully

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants