fix: revert "Fix DNS (#1054)" #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
fix-reworked-dns
branch
from
63d03fd
to
b3d205e
Compare
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
fix-reworked-dns
branch
from
4cf9975
to
74449dc
Compare
edwarnicke
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 31cb2ac.
Description
#1054 totally broke DNS.
#1070 is incorrectly using the cache. We dont want to keep negative responses.
Issue link
Related to networkservicemesh/cmd-nse-l7-proxy#2
How Has This Been Tested?
Types of changes