Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add externaldnscontext networkservice chain element #1295

Merged
merged 2 commits into from
May 17, 2022
Merged

feat: add externaldnscontext networkservice chain element #1295

merged 2 commits into from
May 17, 2022

Conversation

denis-tingaikin
Copy link
Member

@denis-tingaikin denis-tingaikin commented May 17, 2022 •
edited
Loading

Signed-off-by: denis-tingaikin denis.tingajkin@xored.com

Description

This PR simply adds networkservice externaldnscontext chain elements that gets dnsconfigs from the remote side (floating dns service).

Issue link

networkservicemesh/cmd-nse-vl3-vpp#45

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin
add externaldnscontext pkg
34b8726 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
fix typos
f644f34 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@edwarnicke edwarnicke merged commit 1955d61 into networkservicemesh:main May 17, 2022
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request May 17, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8ecd5f8 
…k@main

PR link: networkservicemesh/sdk#1295

Commit: 1955d61
Author: Denis Tingaikin
Date: 2022-05-17 05:08:00 +0300
Message:
  - feat: add externaldnscontext networkservice chain element (#1295)
* add externaldnscontext pkg

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix typos

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request May 17, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8dd6425 
…k@main

PR link: networkservicemesh/sdk#1295

Commit: 1955d61
Author: Denis Tingaikin
Date: 2022-05-17 05:08:00 +0300
Message:
  - feat: add externaldnscontext networkservice chain element (#1295)
* add externaldnscontext pkg

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix typos

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request May 17, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c036d84 
…k@main

PR link: networkservicemesh/sdk#1295

Commit: 1955d61
Author: Denis Tingaikin
Date: 2022-05-17 05:08:00 +0300
Message:
  - feat: add externaldnscontext networkservice chain element (#1295)
* add externaldnscontext pkg

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix typos

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request May 17, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
859de33 
…k@main

PR link: networkservicemesh/sdk#1295

Commit: 1955d61
Author: Denis Tingaikin
Date: 2022-05-17 05:08:00 +0300
Message:
  - feat: add externaldnscontext networkservice chain element (#1295)
* add externaldnscontext pkg

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix typos

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request May 17, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ad457c0 
…k@main

PR link: networkservicemesh/sdk#1295

Commit: 1955d61
Author: Denis Tingaikin
Date: 2022-05-17 05:08:00 +0300
Message:
  - feat: add externaldnscontext networkservice chain element (#1295)
* add externaldnscontext pkg

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix typos

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request May 17, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
07cea3a 
…k@main

PR link: networkservicemesh/sdk#1295

Commit: 1955d61
Author: Denis Tingaikin
Date: 2022-05-17 05:08:00 +0300
Message:
  - feat: add externaldnscontext networkservice chain element (#1295)
* add externaldnscontext pkg

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix typos

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request May 17, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8720c85 
…k@main

PR link: networkservicemesh/sdk#1295

Commit: 1955d61
Author: Denis Tingaikin
Date: 2022-05-17 05:08:00 +0300
Message:
  - feat: add externaldnscontext networkservice chain element (#1295)
* add externaldnscontext pkg

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix typos

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request May 17, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8fe9c0d 
…k@main

PR link: networkservicemesh/sdk#1295

Commit: 1955d61
Author: Denis Tingaikin
Date: 2022-05-17 05:08:00 +0300
Message:
  - feat: add externaldnscontext networkservice chain element (#1295)
* add externaldnscontext pkg

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix typos

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request May 17, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c3b5fd3 
…k@main

PR link: networkservicemesh/sdk#1295

Commit: 1955d61
Author: Denis Tingaikin
Date: 2022-05-17 05:08:00 +0300
Message:
  - feat: add externaldnscontext networkservice chain element (#1295)
* add externaldnscontext pkg

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix typos

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request May 17, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7161b61 
…k@main

PR link: networkservicemesh/sdk#1295

Commit: 1955d61
Author: Denis Tingaikin
Date: 2022-05-17 05:08:00 +0300
Message:
  - feat: add externaldnscontext networkservice chain element (#1295)
* add externaldnscontext pkg

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix typos

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request May 17, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
bc2b36a 
…k@main

PR link: networkservicemesh/sdk#1295

Commit: 1955d61
Author: Denis Tingaikin
Date: 2022-05-17 05:08:00 +0300
Message:
  - feat: add externaldnscontext networkservice chain element (#1295)
* add externaldnscontext pkg

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix typos

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request May 17, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1753b68 
…k@main

PR link: networkservicemesh/sdk#1295

Commit: 1955d61
Author: Denis Tingaikin
Date: 2022-05-17 05:08:00 +0300
Message:
  - feat: add externaldnscontext networkservice chain element (#1295)
* add externaldnscontext pkg

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix typos

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced May 17, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
denis-tingaikin added a commit to denis-tingaikin/sdk that referenced this pull request May 30, 2022
@denis-tingaikin
Revert "feat: add externaldnscontext networkservice chain element (ne…
8378149 
…tworkservicemesh#1295)"

This reverts commit 1955d61.

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
edwarnicke pushed a commit that referenced this pull request May 30, 2022
@denis-tingaikin
Revert "feat: add externaldnscontext networkservice chain element (#1295
776aab6 
)" (#1303)

This reverts commit 1955d61.

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@denis-tingaikin @edwarnicke