Add OPA policies for NSM registries #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
requested review from
fkautz,
glazychev-art,
anastasia-malysheva,
denis-tingaikin,
edwarnicke and
ThetaDR
There was a problem hiding this comment.
Other things looks fine to me.
@edwarnicke Could you have a look?
Comment on lines
37
to
39
| func WithRegisterPolicies(p ...Policy) Option { | ||
| return func(o *options) { | ||
| o.registerPolicies = p | ||
| } | ||
| } | ||
|
|
||
| // WithUnregisterPolicies sets custom policies for unregister check | ||
| func WithUnregisterPolicies(p ...Policy) Option { | ||
| return func(o *options) { | ||
| o.unregisterPolicies = p | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you remind why do we need different setters?
There was a problem hiding this comment.
First one sets policies for Register case
Second one sets policies for Unregister case
NikitaSkrynnik
force-pushed
the
issue-269
branch
from
96cb941
to
fc4b97b
Compare
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
force-pushed
the
issue-269
branch
from
10ef63d
to
a558750
Compare
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
Sep 13, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Sep 13, 2022
…k@main PR link: networkservicemesh/sdk#1334 Commit: a546f3c Author: Nikita Skrynnik Date: 2022-09-13 18:11:13 +0700 Message: - Add OPA policies for NSM registries (#1334) * add auth registy chain element Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add unit test + add test policy Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test policy and policy input Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework spiffieIDNSEMap Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename and move nse register validation policy to opa folder Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add register and unregister policies to authorizeNSEServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add policy for NSE unregister case + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * start adding ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * finish ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add StringSet type Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add authorize registry servers to nsmgr opts Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add default policies to opa registry Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use the same registry for register and unregister cases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * run goimports Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issue Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Sep 13, 2022
…k@main PR link: networkservicemesh/sdk#1334 Commit: a546f3c Author: Nikita Skrynnik Date: 2022-09-13 18:11:13 +0700 Message: - Add OPA policies for NSM registries (#1334) * add auth registy chain element Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add unit test + add test policy Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test policy and policy input Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework spiffieIDNSEMap Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename and move nse register validation policy to opa folder Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add register and unregister policies to authorizeNSEServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add policy for NSE unregister case + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * start adding ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * finish ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add StringSet type Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add authorize registry servers to nsmgr opts Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add default policies to opa registry Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use the same registry for register and unregister cases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * run goimports Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issue Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Sep 13, 2022
…k@main PR link: networkservicemesh/sdk#1334 Commit: a546f3c Author: Nikita Skrynnik Date: 2022-09-13 18:11:13 +0700 Message: - Add OPA policies for NSM registries (#1334) * add auth registy chain element Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add unit test + add test policy Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test policy and policy input Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework spiffieIDNSEMap Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename and move nse register validation policy to opa folder Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add register and unregister policies to authorizeNSEServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add policy for NSE unregister case + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * start adding ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * finish ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add StringSet type Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add authorize registry servers to nsmgr opts Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add default policies to opa registry Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use the same registry for register and unregister cases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * run goimports Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issue Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Sep 13, 2022
…k@main PR link: networkservicemesh/sdk#1334 Commit: a546f3c Author: Nikita Skrynnik Date: 2022-09-13 18:11:13 +0700 Message: - Add OPA policies for NSM registries (#1334) * add auth registy chain element Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add unit test + add test policy Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test policy and policy input Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework spiffieIDNSEMap Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename and move nse register validation policy to opa folder Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add register and unregister policies to authorizeNSEServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add policy for NSE unregister case + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * start adding ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * finish ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add StringSet type Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add authorize registry servers to nsmgr opts Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add default policies to opa registry Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use the same registry for register and unregister cases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * run goimports Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issue Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Sep 13, 2022
…k@main PR link: networkservicemesh/sdk#1334 Commit: a546f3c Author: Nikita Skrynnik Date: 2022-09-13 18:11:13 +0700 Message: - Add OPA policies for NSM registries (#1334) * add auth registy chain element Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add unit test + add test policy Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test policy and policy input Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework spiffieIDNSEMap Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename and move nse register validation policy to opa folder Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add register and unregister policies to authorizeNSEServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add policy for NSE unregister case + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * start adding ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * finish ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add StringSet type Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add authorize registry servers to nsmgr opts Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add default policies to opa registry Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use the same registry for register and unregister cases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * run goimports Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issue Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Sep 13, 2022
…k@main PR link: networkservicemesh/sdk#1334 Commit: a546f3c Author: Nikita Skrynnik Date: 2022-09-13 18:11:13 +0700 Message: - Add OPA policies for NSM registries (#1334) * add auth registy chain element Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add unit test + add test policy Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test policy and policy input Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework spiffieIDNSEMap Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename and move nse register validation policy to opa folder Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add register and unregister policies to authorizeNSEServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add policy for NSE unregister case + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * start adding ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * finish ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add StringSet type Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add authorize registry servers to nsmgr opts Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add default policies to opa registry Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use the same registry for register and unregister cases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * run goimports Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issue Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Sep 13, 2022
…k@main PR link: networkservicemesh/sdk#1334 Commit: a546f3c Author: Nikita Skrynnik Date: 2022-09-13 18:11:13 +0700 Message: - Add OPA policies for NSM registries (#1334) * add auth registy chain element Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add unit test + add test policy Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test policy and policy input Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework spiffieIDNSEMap Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename and move nse register validation policy to opa folder Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add register and unregister policies to authorizeNSEServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add policy for NSE unregister case + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * start adding ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * finish ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add StringSet type Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add authorize registry servers to nsmgr opts Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add default policies to opa registry Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use the same registry for register and unregister cases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * run goimports Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issue Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Sep 13, 2022
…k@main PR link: networkservicemesh/sdk#1334 Commit: a546f3c Author: Nikita Skrynnik Date: 2022-09-13 18:11:13 +0700 Message: - Add OPA policies for NSM registries (#1334) * add auth registy chain element Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add unit test + add test policy Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test policy and policy input Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework spiffieIDNSEMap Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename and move nse register validation policy to opa folder Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add register and unregister policies to authorizeNSEServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add policy for NSE unregister case + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * start adding ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * finish ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add StringSet type Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add authorize registry servers to nsmgr opts Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add default policies to opa registry Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use the same registry for register and unregister cases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * run goimports Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issue Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Sep 13, 2022
…k@main PR link: networkservicemesh/sdk#1334 Commit: a546f3c Author: Nikita Skrynnik Date: 2022-09-13 18:11:13 +0700 Message: - Add OPA policies for NSM registries (#1334) * add auth registy chain element Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add unit test + add test policy Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test policy and policy input Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework spiffieIDNSEMap Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename and move nse register validation policy to opa folder Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add register and unregister policies to authorizeNSEServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add policy for NSE unregister case + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * start adding ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * finish ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add StringSet type Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add authorize registry servers to nsmgr opts Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add default policies to opa registry Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use the same registry for register and unregister cases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * run goimports Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issue Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Sep 13, 2022
…k@main PR link: networkservicemesh/sdk#1334 Commit: a546f3c Author: Nikita Skrynnik Date: 2022-09-13 18:11:13 +0700 Message: - Add OPA policies for NSM registries (#1334) * add auth registy chain element Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add unit test + add test policy Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test policy and policy input Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework spiffieIDNSEMap Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename and move nse register validation policy to opa folder Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add register and unregister policies to authorizeNSEServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add policy for NSE unregister case + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * start adding ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * finish ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add StringSet type Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add authorize registry servers to nsmgr opts Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add default policies to opa registry Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use the same registry for register and unregister cases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * run goimports Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issue Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Sep 13, 2022
…k@main PR link: networkservicemesh/sdk#1334 Commit: a546f3c Author: Nikita Skrynnik Date: 2022-09-13 18:11:13 +0700 Message: - Add OPA policies for NSM registries (#1334) * add auth registy chain element Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add unit test + add test policy Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test policy and policy input Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework spiffieIDNSEMap Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename and move nse register validation policy to opa folder Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add register and unregister policies to authorizeNSEServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add policy for NSE unregister case + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * start adding ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * finish ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add StringSet type Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add authorize registry servers to nsmgr opts Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add default policies to opa registry Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use the same registry for register and unregister cases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * run goimports Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issue Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Sep 13, 2022
…k@main PR link: networkservicemesh/sdk#1334 Commit: a546f3c Author: Nikita Skrynnik Date: 2022-09-13 18:11:13 +0700 Message: - Add OPA policies for NSM registries (#1334) * add auth registy chain element Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add unit test + add test policy Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix test policy and policy input Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework spiffieIDNSEMap Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rename and move nse register validation policy to opa folder Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add register and unregister policies to authorizeNSEServer Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add policy for NSE unregister case + cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * start adding ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * finish ns_server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add StringSet type Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * cleanup Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add authorize registry servers to nsmgr opts Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add default policies to opa registry Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use the same registry for register and unregister cases Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * run goimports Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issue Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue link
#269
How Has This Been Tested?
Types of changes