Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix begin on refresh #1365

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Fix begin on refresh #1365

merged 1 commit into from
Oct 12, 2022

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Oct 11, 2022 •
edited
Loading

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

Steps to reproduce:

  1. Deploy any NSM remote case (for example kernel2vxlan2kernel)
  2. Delete remote Nsmgr pod
  3. Wait for a new Nsmgr
  4. Delete NSE pod
    See - network service endpoint {NAME} not found: all forwarders have failed

Why is this happening?

After restarting the remote Nsmgr, it reconnects to the remote Forwarder with the same connID, but with a different context values (this is needed for authorize chain element).
begin has a map that stores the eventFactory by connID. When the recreated Nsmgr reaches the Forwarder, we use the previous eventFactory with the old internal context.

After that, all calls from eventFactory will fail. For example, nsmonitor will not work on forwarder. And it affects the healing.

Issue link

#1357

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@glazychev-art
Fix begin on refresh
8f6f8ba 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@glazychev-art glazychev-art marked this pull request as ready for review October 11, 2022 12:41
@denis-tingaikin denis-tingaikin merged commit 6c3f844 into networkservicemesh:main Oct 12, 2022
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Oct 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
89832c3 
…k@main

PR link: networkservicemesh/sdk#1365

Commit: 6c3f844
Author: Artem Glazychev
Date: 2022-10-12 21:27:42 +0700
Message:
  - Fix begin on refresh (#1365)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Oct 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
907d61b 
…k@main

PR link: networkservicemesh/sdk#1365

Commit: 6c3f844
Author: Artem Glazychev
Date: 2022-10-12 21:27:42 +0700
Message:
  - Fix begin on refresh (#1365)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Oct 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e57d6a8 
…k@main

PR link: networkservicemesh/sdk#1365

Commit: 6c3f844
Author: Artem Glazychev
Date: 2022-10-12 21:27:42 +0700
Message:
  - Fix begin on refresh (#1365)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Oct 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2064683 
…k@main

PR link: networkservicemesh/sdk#1365

Commit: 6c3f844
Author: Artem Glazychev
Date: 2022-10-12 21:27:42 +0700
Message:
  - Fix begin on refresh (#1365)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Oct 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1e4ac95 
…k@main

PR link: networkservicemesh/sdk#1365

Commit: 6c3f844
Author: Artem Glazychev
Date: 2022-10-12 21:27:42 +0700
Message:
  - Fix begin on refresh (#1365)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Oct 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e5aef33 
…k@main

PR link: networkservicemesh/sdk#1365

Commit: 6c3f844
Author: Artem Glazychev
Date: 2022-10-12 21:27:42 +0700
Message:
  - Fix begin on refresh (#1365)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Oct 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a5bd03d 
…k@main

PR link: networkservicemesh/sdk#1365

Commit: 6c3f844
Author: Artem Glazychev
Date: 2022-10-12 21:27:42 +0700
Message:
  - Fix begin on refresh (#1365)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Oct 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f568000 
…k@main

PR link: networkservicemesh/sdk#1365

Commit: 6c3f844
Author: Artem Glazychev
Date: 2022-10-12 21:27:42 +0700
Message:
  - Fix begin on refresh (#1365)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Oct 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
39a13f0 
…k@main

PR link: networkservicemesh/sdk#1365

Commit: 6c3f844
Author: Artem Glazychev
Date: 2022-10-12 21:27:42 +0700
Message:
  - Fix begin on refresh (#1365)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Oct 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6010622 
…k@main

PR link: networkservicemesh/sdk#1365

Commit: 6c3f844
Author: Artem Glazychev
Date: 2022-10-12 21:27:42 +0700
Message:
  - Fix begin on refresh (#1365)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Oct 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
de1dcfd 
…k@main

PR link: networkservicemesh/sdk#1365

Commit: 6c3f844
Author: Artem Glazychev
Date: 2022-10-12 21:27:42 +0700
Message:
  - Fix begin on refresh (#1365)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Oct 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fe3c21d 
…k@main

PR link: networkservicemesh/sdk#1365

Commit: 6c3f844
Author: Artem Glazychev
Date: 2022-10-12 21:27:42 +0700
Message:
  - Fix begin on refresh (#1365)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Oct 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
900a3f0 
…k@main

PR link: networkservicemesh/sdk#1365

Commit: 6c3f844
Author: Artem Glazychev
Date: 2022-10-12 21:27:42 +0700
Message:
  - Fix begin on refresh (#1365)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 12, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@nsmbot nsmbot mentioned this pull request Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwarnicke edwarnicke edwarnicke approved these changes

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glazychev-art @edwarnicke @denis-tingaikin