Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

begin: use the eventFactory context to close eventFactory connection #1487

Merged
merged 2 commits into from
Jul 10, 2023
Merged

begin: use the eventFactory context to close eventFactory connection #1487

merged 2 commits into from
Jul 10, 2023

Conversation

glazychev-art
Copy link
Contributor

Description

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@glazychev-art
begin: use the eventFactory context to close eventFactory connection
4e81ae5 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@7ec603e). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 4e81ae5 differs from pull request most recent head a8bcca8. Consider uploading reports for the commit a8bcca8 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1487   +/-   ##
=======================================
  Coverage        ?   70.31%           
=======================================
  Files           ?      248           
  Lines           ?    11198           
  Branches        ?        0           
=======================================
  Hits            ?     7874           
  Misses          ?     2822           
  Partials        ?      502

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glazychev-art
skip Test_DiscoverForwarder_Should_KeepSelectedForwarderWhileConnecti…
a8bcca8 
…onIsFine

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit 01bb35f into networkservicemesh:main Jul 10, 2023
15 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Jul 10, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4095b0b 
…k@main

PR link: networkservicemesh/sdk#1487

Commit: 01bb35f
Author: Artem Glazychev
Date: 2023-07-10 17:07:21 +0700
Message:
  - begin: use the eventFactory context to close eventFactory connection (#1487)
* begin: use the eventFactory context to close eventFactory connection

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* skip Test_DiscoverForwarder_Should_KeepSelectedForwarderWhileConnectionIsFine

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Jul 10, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d1b795f 
…k@main

PR link: networkservicemesh/sdk#1487

Commit: 01bb35f
Author: Artem Glazychev
Date: 2023-07-10 17:07:21 +0700
Message:
  - begin: use the eventFactory context to close eventFactory connection (#1487)
* begin: use the eventFactory context to close eventFactory connection

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* skip Test_DiscoverForwarder_Should_KeepSelectedForwarderWhileConnectionIsFine

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jul 10, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9265c55 
…k@main

PR link: networkservicemesh/sdk#1487

Commit: 01bb35f
Author: Artem Glazychev
Date: 2023-07-10 17:07:21 +0700
Message:
  - begin: use the eventFactory context to close eventFactory connection (#1487)
* begin: use the eventFactory context to close eventFactory connection

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* skip Test_DiscoverForwarder_Should_KeepSelectedForwarderWhileConnectionIsFine

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jul 10, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
81b981e 
…k@main

PR link: networkservicemesh/sdk#1487

Commit: 01bb35f
Author: Artem Glazychev
Date: 2023-07-10 17:07:21 +0700
Message:
  - begin: use the eventFactory context to close eventFactory connection (#1487)
* begin: use the eventFactory context to close eventFactory connection

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* skip Test_DiscoverForwarder_Should_KeepSelectedForwarderWhileConnectionIsFine

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jul 10, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
35231f3 
…k@main

PR link: networkservicemesh/sdk#1487

Commit: 01bb35f
Author: Artem Glazychev
Date: 2023-07-10 17:07:21 +0700
Message:
  - begin: use the eventFactory context to close eventFactory connection (#1487)
* begin: use the eventFactory context to close eventFactory connection

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* skip Test_DiscoverForwarder_Should_KeepSelectedForwarderWhileConnectionIsFine

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jul 10, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
79a06fa 
…k@main

PR link: networkservicemesh/sdk#1487

Commit: 01bb35f
Author: Artem Glazychev
Date: 2023-07-10 17:07:21 +0700
Message:
  - begin: use the eventFactory context to close eventFactory connection (#1487)
* begin: use the eventFactory context to close eventFactory connection

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* skip Test_DiscoverForwarder_Should_KeepSelectedForwarderWhileConnectionIsFine

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jul 10, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c194638 
…k@main

PR link: networkservicemesh/sdk#1487

Commit: 01bb35f
Author: Artem Glazychev
Date: 2023-07-10 17:07:21 +0700
Message:
  - begin: use the eventFactory context to close eventFactory connection (#1487)
* begin: use the eventFactory context to close eventFactory connection

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* skip Test_DiscoverForwarder_Should_KeepSelectedForwarderWhileConnectionIsFine

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Jul 10, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
756dfc3 
…k@main

PR link: networkservicemesh/sdk#1487

Commit: 01bb35f
Author: Artem Glazychev
Date: 2023-07-10 17:07:21 +0700
Message:
  - begin: use the eventFactory context to close eventFactory connection (#1487)
* begin: use the eventFactory context to close eventFactory connection

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* skip Test_DiscoverForwarder_Should_KeepSelectedForwarderWhileConnectionIsFine

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Jul 10, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1fa5075 
…k@main

PR link: networkservicemesh/sdk#1487

Commit: 01bb35f
Author: Artem Glazychev
Date: 2023-07-10 17:07:21 +0700
Message:
  - begin: use the eventFactory context to close eventFactory connection (#1487)
* begin: use the eventFactory context to close eventFactory connection

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* skip Test_DiscoverForwarder_Should_KeepSelectedForwarderWhileConnectionIsFine

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jul 10, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
20108bb 
…k@main

PR link: networkservicemesh/sdk#1487

Commit: 01bb35f
Author: Artem Glazychev
Date: 2023-07-10 17:07:21 +0700
Message:
  - begin: use the eventFactory context to close eventFactory connection (#1487)
* begin: use the eventFactory context to close eventFactory connection

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* skip Test_DiscoverForwarder_Should_KeepSelectedForwarderWhileConnectionIsFine

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jul 10, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c4ff8fe 
…k@main

PR link: networkservicemesh/sdk#1487

Commit: 01bb35f
Author: Artem Glazychev
Date: 2023-07-10 17:07:21 +0700
Message:
  - begin: use the eventFactory context to close eventFactory connection (#1487)
* begin: use the eventFactory context to close eventFactory connection

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* skip Test_DiscoverForwarder_Should_KeepSelectedForwarderWhileConnectionIsFine

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jul 10, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e76fb09 
…k@main

PR link: networkservicemesh/sdk#1487

Commit: 01bb35f
Author: Artem Glazychev
Date: 2023-07-10 17:07:21 +0700
Message:
  - begin: use the eventFactory context to close eventFactory connection (#1487)
* begin: use the eventFactory context to close eventFactory connection

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* skip Test_DiscoverForwarder_Should_KeepSelectedForwarderWhileConnectionIsFine

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jul 10, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f3bc5c1 
…k@main

PR link: networkservicemesh/sdk#1487

Commit: 01bb35f
Author: Artem Glazychev
Date: 2023-07-10 17:07:21 +0700
Message:
  - begin: use the eventFactory context to close eventFactory connection (#1487)
* begin: use the eventFactory context to close eventFactory connection

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* skip Test_DiscoverForwarder_Should_KeepSelectedForwarderWhileConnectionIsFine

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jul 10, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
38447be 
…k@main

PR link: networkservicemesh/sdk#1487

Commit: 01bb35f
Author: Artem Glazychev
Date: 2023-07-10 17:07:21 +0700
Message:
  - begin: use the eventFactory context to close eventFactory connection (#1487)
* begin: use the eventFactory context to close eventFactory connection

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

* skip Test_DiscoverForwarder_Should_KeepSelectedForwarderWhileConnectionIsFine

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jul 10, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 10, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glazychev-art @denis-tingaikin