Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qfix: Use strict name comparison for nse/ns servers #1530

Merged
merged 1 commit into from
Oct 17, 2023
Merged

qfix: Use strict name comparison for nse/ns servers #1530

merged 1 commit into from
Oct 17, 2023

Conversation

denis-tingaikin
Copy link
Member

Description

Related to discussion about #1521 from WG call

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin denis-tingaikin marked this pull request as ready for review October 16, 2023 16:05
@denis-tingaikin denis-tingaikin changed the title qfix: Use strict name comparison qfix: Use strict name comparison for nse/ns servers Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@836a51c). Click here to learn what that means.

❗ Current head c86fef0 differs from pull request most recent head f5ea5fb. Consider uploading reports for the commit f5ea5fb to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1530   +/-   ##
=======================================
  Coverage        ?   66.86%           
=======================================
  Files           ?      259           
  Lines           ?    12336           
  Branches        ?        0           
=======================================
  Hits            ?     8249           
  Misses          ?     3564           
  Partials        ?      523

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-tingaikin
use strict name comparison for nse/ns find query
f5ea5fb 
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@glazychev-art glazychev-art merged commit 02ca02e into main Oct 17, 2023
15 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Oct 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
69e3e78 
…k@main

PR link: networkservicemesh/sdk#1530

Commit: 02ca02e
Author: Denis Tingaikin
Date: 2023-10-17 14:05:04 +0300
Message:
  - use strict name comparison  for nse/ns find query (#1530)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Oct 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
32bb2fc 
…k@main

PR link: networkservicemesh/sdk#1530

Commit: 02ca02e
Author: Denis Tingaikin
Date: 2023-10-17 14:05:04 +0300
Message:
  - use strict name comparison  for nse/ns find query (#1530)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Oct 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e9b3ab7 
…k@main

PR link: networkservicemesh/sdk#1530

Commit: 02ca02e
Author: Denis Tingaikin
Date: 2023-10-17 14:05:04 +0300
Message:
  - use strict name comparison  for nse/ns find query (#1530)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Oct 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
df830bb 
…k@main

PR link: networkservicemesh/sdk#1530

Commit: 02ca02e
Author: Denis Tingaikin
Date: 2023-10-17 14:05:04 +0300
Message:
  - use strict name comparison  for nse/ns find query (#1530)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Oct 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
41f1fe3 
…k@main

PR link: networkservicemesh/sdk#1530

Commit: 02ca02e
Author: Denis Tingaikin
Date: 2023-10-17 14:05:04 +0300
Message:
  - use strict name comparison  for nse/ns find query (#1530)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Oct 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9aacf97 
…k@main

PR link: networkservicemesh/sdk#1530

Commit: 02ca02e
Author: Denis Tingaikin
Date: 2023-10-17 14:05:04 +0300
Message:
  - use strict name comparison  for nse/ns find query (#1530)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Oct 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
03687b8 
…k@main

PR link: networkservicemesh/sdk#1530

Commit: 02ca02e
Author: Denis Tingaikin
Date: 2023-10-17 14:05:04 +0300
Message:
  - use strict name comparison  for nse/ns find query (#1530)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Oct 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
94573d0 
…k@main

PR link: networkservicemesh/sdk#1530

Commit: 02ca02e
Author: Denis Tingaikin
Date: 2023-10-17 14:05:04 +0300
Message:
  - use strict name comparison  for nse/ns find query (#1530)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 17, 2023
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Oct 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
591cc5e 
…k@main

PR link: networkservicemesh/sdk#1530

Commit: 02ca02e
Author: Denis Tingaikin
Date: 2023-10-17 14:05:04 +0300
Message:
  - use strict name comparison  for nse/ns find query (#1530)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Oct 17, 2023
Merged
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Oct 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
68f9dc6 
…k@main

PR link: networkservicemesh/sdk#1530

Commit: 02ca02e
Author: Denis Tingaikin
Date: 2023-10-17 14:05:04 +0300
Message:
  - use strict name comparison  for nse/ns find query (#1530)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Oct 17, 2023
Merged
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Oct 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c03b266 
…k@main

PR link: networkservicemesh/sdk#1530

Commit: 02ca02e
Author: Denis Tingaikin
Date: 2023-10-17 14:05:04 +0300
Message:
  - use strict name comparison  for nse/ns find query (#1530)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 17, 2023
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Oct 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ffcb2f8 
…k@main

PR link: networkservicemesh/sdk#1530

Commit: 02ca02e
Author: Denis Tingaikin
Date: 2023-10-17 14:05:04 +0300
Message:
  - use strict name comparison  for nse/ns find query (#1530)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Oct 17, 2023
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Oct 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
87e8f86 
…k@main

PR link: networkservicemesh/sdk#1530

Commit: 02ca02e
Author: Denis Tingaikin
Date: 2023-10-17 14:05:04 +0300
Message:
  - use strict name comparison  for nse/ns find query (#1530)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 17, 2023
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Oct 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
903ad3c 
…k@main

PR link: networkservicemesh/sdk#1530

Commit: 02ca02e
Author: Denis Tingaikin
Date: 2023-10-17 14:05:04 +0300
Message:
  - use strict name comparison  for nse/ns find query (#1530)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glazychev-art glazychev-art glazychev-art approved these changes

@bellycat77 bellycat77 bellycat77 approved these changes

@NikitaSkrynnik NikitaSkrynnik NikitaSkrynnik approved these changes

@d-uzlov d-uzlov Awaiting requested review from d-uzlov

@dualBreath dualBreath Awaiting requested review from dualBreath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@denis-tingaikin @glazychev-art @bellycat77 @NikitaSkrynnik