Broken "cloud.google.com/go/compute/metadata" dependency #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1555 +/- ##
=======================================
Coverage ? 66.86%
=======================================
Files ? 259
Lines ? 12327
Branches ? 0
=======================================
Hits ? 8242
Misses ? 3566
Partials ? 519 ☔ View full report in Codecov by Sentry. |
| go.opentelemetry.io/otel/sdk/metric v1.19.0-rc.1 | ||
| go.opentelemetry.io/otel/trace v1.19.0-rc.1 | ||
| go.opentelemetry.io/otel v1.20.0 | ||
| go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.43.0 |
There was a problem hiding this comment.
This version contains CVE-2023-47108, could you update otel to v0.46.0?
Suggested change
| go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.43.0 | |
| go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.46.0 |
There was a problem hiding this comment.
Have you specified the correct dependency? It is the latest one:
There was a problem hiding this comment.
I've updated go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to version v0.46.0. Hope this will solve the problem
There was a problem hiding this comment.
This seems to break the build. I'll revert this change and try to update the version in a separate task.
There was a problem hiding this comment.
I've updated go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to version v0.46.0 and disabled linter
|
@denis-tingaikin @NikitaSkrynnik @glazychev-art @d-uzlov @VitalyGushin please take a look |
added 3 commits
November 13, 2023 16:21
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
…olang.org/grpc/otelgrpc version Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
denis-tingaikin
approved these changes
Nov 14, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Nov 14, 2023
…k@main PR link: networkservicemesh/sdk#1555 Commit: 70f3d88 Author: Alexander Peretyatko Date: 2023-11-14 21:15:17 +0700 Message: - Broken "cloud.google.com/go/compute/metadata" dependency (#1555) * Task:1551 Fix problem with cloud.google.com/go/compute/metadata dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update vulnerable dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 revert version update that brokes the build Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc version Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Nov 14, 2023
…k@main PR link: networkservicemesh/sdk#1555 Commit: 70f3d88 Author: Alexander Peretyatko Date: 2023-11-14 21:15:17 +0700 Message: - Broken "cloud.google.com/go/compute/metadata" dependency (#1555) * Task:1551 Fix problem with cloud.google.com/go/compute/metadata dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update vulnerable dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 revert version update that brokes the build Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc version Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Nov 14, 2023
…k@main PR link: networkservicemesh/sdk#1555 Commit: 70f3d88 Author: Alexander Peretyatko Date: 2023-11-14 21:15:17 +0700 Message: - Broken "cloud.google.com/go/compute/metadata" dependency (#1555) * Task:1551 Fix problem with cloud.google.com/go/compute/metadata dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update vulnerable dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 revert version update that brokes the build Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc version Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Nov 14, 2023
…k@main PR link: networkservicemesh/sdk#1555 Commit: 70f3d88 Author: Alexander Peretyatko Date: 2023-11-14 21:15:17 +0700 Message: - Broken "cloud.google.com/go/compute/metadata" dependency (#1555) * Task:1551 Fix problem with cloud.google.com/go/compute/metadata dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update vulnerable dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 revert version update that brokes the build Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc version Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Nov 14, 2023
…k@main PR link: networkservicemesh/sdk#1555 Commit: 70f3d88 Author: Alexander Peretyatko Date: 2023-11-14 21:15:17 +0700 Message: - Broken "cloud.google.com/go/compute/metadata" dependency (#1555) * Task:1551 Fix problem with cloud.google.com/go/compute/metadata dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update vulnerable dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 revert version update that brokes the build Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc version Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 14, 2023
…k@main PR link: networkservicemesh/sdk#1555 Commit: 70f3d88 Author: Alexander Peretyatko Date: 2023-11-14 21:15:17 +0700 Message: - Broken "cloud.google.com/go/compute/metadata" dependency (#1555) * Task:1551 Fix problem with cloud.google.com/go/compute/metadata dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update vulnerable dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 revert version update that brokes the build Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc version Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Nov 14, 2023
…k@main PR link: networkservicemesh/sdk#1555 Commit: 70f3d88 Author: Alexander Peretyatko Date: 2023-11-14 21:15:17 +0700 Message: - Broken "cloud.google.com/go/compute/metadata" dependency (#1555) * Task:1551 Fix problem with cloud.google.com/go/compute/metadata dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update vulnerable dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 revert version update that brokes the build Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc version Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Nov 14, 2023
…k@main PR link: networkservicemesh/sdk#1555 Commit: 70f3d88 Author: Alexander Peretyatko Date: 2023-11-14 21:15:17 +0700 Message: - Broken "cloud.google.com/go/compute/metadata" dependency (#1555) * Task:1551 Fix problem with cloud.google.com/go/compute/metadata dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update vulnerable dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 revert version update that brokes the build Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc version Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Nov 14, 2023
…k@main PR link: networkservicemesh/sdk#1555 Commit: 70f3d88 Author: Alexander Peretyatko Date: 2023-11-14 21:15:17 +0700 Message: - Broken "cloud.google.com/go/compute/metadata" dependency (#1555) * Task:1551 Fix problem with cloud.google.com/go/compute/metadata dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update vulnerable dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 revert version update that brokes the build Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc version Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 14, 2023
…k@main PR link: networkservicemesh/sdk#1555 Commit: 70f3d88 Author: Alexander Peretyatko Date: 2023-11-14 21:15:17 +0700 Message: - Broken "cloud.google.com/go/compute/metadata" dependency (#1555) * Task:1551 Fix problem with cloud.google.com/go/compute/metadata dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update vulnerable dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 revert version update that brokes the build Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc version Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Nov 14, 2023
…k@main PR link: networkservicemesh/sdk#1555 Commit: 70f3d88 Author: Alexander Peretyatko Date: 2023-11-14 21:15:17 +0700 Message: - Broken "cloud.google.com/go/compute/metadata" dependency (#1555) * Task:1551 Fix problem with cloud.google.com/go/compute/metadata dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update vulnerable dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 revert version update that brokes the build Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc version Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Nov 14, 2023
…k@main PR link: networkservicemesh/sdk#1555 Commit: 70f3d88 Author: Alexander Peretyatko Date: 2023-11-14 21:15:17 +0700 Message: - Broken "cloud.google.com/go/compute/metadata" dependency (#1555) * Task:1551 Fix problem with cloud.google.com/go/compute/metadata dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update vulnerable dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 revert version update that brokes the build Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc version Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 14, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Nov 14, 2023
…k@main PR link: networkservicemesh/sdk#1555 Commit: 70f3d88 Author: Alexander Peretyatko Date: 2023-11-14 21:15:17 +0700 Message: - Broken "cloud.google.com/go/compute/metadata" dependency (#1555) * Task:1551 Fix problem with cloud.google.com/go/compute/metadata dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update vulnerable dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 revert version update that brokes the build Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc version Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Nov 14, 2023
…k@main PR link: networkservicemesh/sdk#1555 Commit: 70f3d88 Author: Alexander Peretyatko Date: 2023-11-14 21:15:17 +0700 Message: - Broken "cloud.google.com/go/compute/metadata" dependency (#1555) * Task:1551 Fix problem with cloud.google.com/go/compute/metadata dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update vulnerable dependency Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 revert version update that brokes the build Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> * Task:1551 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc version Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 14, 2023
This was referenced Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
go mod tidydoesn't work due to problematic dependency "cloud.google.com/go/compute/metadata"Issue link
#1551
How Has This Been Tested?
Types of changes