Updated spire to handle entries via options #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out, spire-agent only polls spire-server every 5 seconds. This means that if we run spire-server, then spire-agent, then add entries... it can take up to six seconds to get our SVID. By moving to options, we can: 1. Start spire-server 2. Create entries 3. Start spire-agent And spire-agent *starts* with the entries and can thus issue ids. Signed-off-by: Ed Warnicke <hagbard@gmail.com>
edwarnicke
added a commit
to edwarnicke/cmd-forwarder-vppagent
that referenced
this pull request
May 27, 2020
networkservicemesh/sdk#258 Signed-off-by: Ed Warnicke <hagbard@gmail.com>
fkautz
approved these changes
May 27, 2020
edwarnicke
added a commit
to edwarnicke/cmd-forwarder-vppagent
that referenced
this pull request
May 27, 2020
networkservicemesh/sdk#258 Signed-off-by: Ed Warnicke <hagbard@gmail.com>
edwarnicke
added a commit
to edwarnicke/cmd-forwarder-vppagent
that referenced
this pull request
May 27, 2020
networkservicemesh/sdk#258 Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out, spire-agent only polls spire-server
every 5 seconds. This means that if we run spire-server, then
spire-agent, then add entries... it can take up to six seconds
to get our SVID.
By moving to options, we can:
And spire-agent starts with the entries and can thus issue ids.