Rework timeout chain element

[Bolodya1997]

Timeout chain element use not returned connection value, but incoming - it is wrong because subsequent chain elements can edit connection and fail to close not edited connection.
UPD: #551

[denis-tingaikin]

In general looks good

[Bolodya1997]

Issue

all values from the current context are copied including next.Server()

time.AfterFunc(duration, func() {
	newCtx := extend.WithValuesFromContext(context.Background(), ctx)
	if _, err := (*t.onTimeout).Close(newCtx, conn); err != nil {
		trace.Log(newCtx).Errorf("Error attempting to close timed out connection: %s: %+v", request.GetConnection().GetId(), err)
	}
}

for the Close chain it looks like it was injected between the timeout and the after-timeout chain elements

if n.index == 0 && ctx != nil {
	if np := Server(ctx); np != nil {
		nextParent = np
	}
}

Solution

time.AfterFunc(duration, func() {
	newCtx := extend.WithValuesFromContext(context.Background(), ctx)
	closeServer := chain.NewNetworkServiceServer(*t.onTimeout, next.TailServer())
	if _, err := closeServer.Close(newCtx, conn); err != nil {
		trace.Log(newCtx).Errorf("Error attempting to close timed out connection: %s: %+v", conn.GetId(), err)
	}
})

[denis-tingaikin]

I think it is the wrong way for chains.
We should not add new kinds of chains like a breakchain that means a chain that doesn't call parent chains... I feel it will make the system more complex.

Let's just rework timeout with the next approach:

package timeout

// Timeout just closes all next elements from the context on timeout
func NewServer() {
}

[edwarnicke]

I think this may be simpler: #547

[Bolodya1997]

Depends on: #542.

[denis-tingaikin]

LGTM

@edwarnicke Do you have any comments on this PR?

[denis-tingaikin]

@edwarnicke Let us know if you have any comments on this then we'll fix them in separate PRs