Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade structlog, packaging dependencies #211

Merged
merged 3 commits into from
Mar 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion examples/03-remote-system/diff.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ class AlphabeticalOrderDiff(Diff):
def order_children_default(cls, children):
"""Simple diff to return all children in alphabetical order."""
for child in sorted(children.values()):

# it's possible to access additional information about the object
# like child.action can be "update", "create" or "delete"

Expand Down
1 change: 0 additions & 1 deletion examples/03-remote-system/local_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ def load(self, filename=COUNTRIES_FILE): # pylint: disable=arguments-differ
# A Country object will be created for each country, it will be stored inside the adapter with self.add(),
# and it will be linked to its parent with parent.add_child(item)
for country in countries:

# Retrive the parent region object from the internal cache.
region = self.get(obj=self.region, identifier=slugify(country.get("region")))

Expand Down
86 changes: 42 additions & 44 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ include = [
[tool.poetry.dependencies]
python = "^3.7"
pydantic = "^1.7.4,!=1.8,!=1.8.1"
structlog = ">= 20.1.0, < 22.0.0"
packaging = "^21.3"
structlog = ">= 20.1.0, < 23.0.0"
packaging = ">= 21.3, < 24.0"
colorama = {version = "^0.4.3", optional = true}
redis = {version = "^4.3", optional = true}

Expand Down
1 change: 1 addition & 0 deletions tests/unit/test_diffsync_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ class AttrChildOverlap(DiffSyncModel):

def test_diffsync_model_subclass_inheritance():
"""Verify that the class validation works properly even with a hierarchy of subclasses."""

# Pylint would complain because we're not actually using any of the classes declared below
# pylint: disable=unused-variable
class Alpha(DiffSyncModel):
Expand Down