Skip to content

Commit

Permalink
Adding nxos_ssh to Napalm mapper (#138)
Browse files Browse the repository at this point in the history
  • Loading branch information
joewesch committed Aug 4, 2022
1 parent 723d040 commit 4a26bcb
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Expand Up @@ -24,7 +24,7 @@ Functions are grouped with like functions, such as IP or MAC address based funct
* Compliance - Provides the ability to compare two configurations to sanely understand the differences.
* Parsing - Provides the ability to parse configuration for the minor differences that are there.
* DNS - Provides the ability to work with DNS, such as validating that a FQDN is resolvable.
* Interface - Provides the ability to work with interface names, expanding, abbreviating, and spliting the names.
* Interface - Provides the ability to work with interface names, expanding, abbreviating, and splitting the names.
* IP Address - Provides the ability to work with IP addresses, primarily exposing Python `ipaddress` functionality.
* Library Mapper - Provides mappings in expected vendor names between Netmiko, NAPALM, pyntc, ntc-templates, pyats, and scrapli.
* MAC Address - Provides the ability to work with MAC addresses such as validating or converting to integer.
Expand Down Expand Up @@ -160,7 +160,7 @@ There are a number of things that are required in order to have a successful PR.
- All new functions must contain at least 1 example in their docstrings.
- Docstrings must conform to the google docstring [convention](https://google.github.io/styleguide/pyguide.html#381-docstrings).
- Unit test for newly added functions are required.
- If applicable, tests related to config parsing and compliuance must be added.
- If applicable, tests related to config parsing and compliance must be added.
- Update the jinja2 filter (netutils.utils.jinja2_convenience_function) for any new functions (see below for details).
- If you create a new file in the `netutils` folder, you must create a new folder and `index.rst` in the docs folder (see below for details).
- Your PR must not introduce any required dependencies. You can introduce optional or development dependencies.
Expand Down
3 changes: 3 additions & 0 deletions docs/source/netutils/lib_mapping/NAPALM_table.rst
Expand Up @@ -21,6 +21,9 @@
<tr>
<td>ios</td><td>cisco_ios</td>
</tr>
<tr>
<td>nxos_ssh</td><td>cisco_nxos</td>
</tr>
<tr>
<td>nxos</td><td>cisco_nxos</td>
</tr>
Expand Down
1 change: 1 addition & 0 deletions netutils/lib_mapper.py
Expand Up @@ -131,6 +131,7 @@
"fortios": "fortinet",
"huawei": "huawei_vrp",
"ios": "cisco_ios",
"nxos_ssh": "cisco_nxos",
"nxos": "cisco_nxos",
"iosxr": "cisco_xr",
"junos": "juniper_junos",
Expand Down

0 comments on commit 4a26bcb

Please sign in to comment.