Add IPv6 functionality to ip module. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove redundant call to `str` - `get_all_host` list to generator to avoid memory overhead of very large lists
There are only 32 + 128 valid IPv4/6 netmasks, so I created a lookup table for easy validation. If there are concerns about the memory overhead, a computed version is easy enough to implement.
I modified functions where I could to make them compatible with IPv6. Per [RFC4291](https://datatracker.ietf.org/doc/html/rfc4291#section-4), I have assumed any addresses in the ::/8 range are IPv4. The one exception is `cidr_to_netmask`. I added a v6 version of that function.
dgjustice
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
netutils/ip.py
Outdated
| @@ -247,3 +272,25 @@ def get_usable_range(ip_network): | |||
| lower_bound = str(net[1]) | |||
| upper_bound = str(net[-2]) | |||
| return f"{lower_bound} - {upper_bound}" | |||
|
|
|||
|
|
|||
| def count_bits(i: int) -> int: | |||
There was a problem hiding this comment.
Should this be a private method?
Also, should avoid using single letter variable names.
| def get_all_host(ip_network): | ||
| """Given a network, return the list of usable IP addresses. | ||
|
|
||
| Args: | ||
| ip_network (str): An IP network in string format that is able to be converted by `ipaddress` library. | ||
|
|
||
| Returns: | ||
| list: List of usable IP Addresses within network. | ||
| generator: Generator of usable IP Addresses within network. |
There was a problem hiding this comment.
I can go either way on this, performance is obviously better as a generator, but just want to make sure it makes sense for the masses.
There was a problem hiding this comment.
I can yank this out if you like.
|
Thanks!! Mostly just a bunch of nit's, but appreciate the addition. |
jeffkala
approved these changes
Jun 21, 2021
|
Last nit for me, can you remove any single letter variables? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dual-stack functionality anywhere it was missing. Please see commit comments for more details. The one oddball is
cidr_to_netmaskbecause of the ambiguity in translating valid masks <= 32.