Ruckus fastiron parser #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pato23arg
commented
Apr 18, 2023
pato23arg
commented
- support for ruckus fastiron ICX switches
new file: tests/unit/mock/config/compliance/compliance/ruckus_fastiron/fastiron_basic_backup.txt new file: tests/unit/mock/config/compliance/compliance/ruckus_fastiron/fastiron_basic_feature.py new file: tests/unit/mock/config/compliance/compliance/ruckus_fastiron/fastiron_basic_intended.txt new file: tests/unit/mock/config/compliance/compliance/ruckus_fastiron/fastiron_basic_received.json
…n_full_received.py new file: tests/unit/mock/config/parser/base/ruckus_fastiron/fastiron_full_sent.txt
…on/fastiron_basic_backup.txt modified: tests/unit/mock/config/compliance/compliance/ruckus_fastiron/fastiron_basic_intended.txt modified: tests/unit/mock/config/compliance/compliance/ruckus_fastiron/fastiron_basic_received.json
modified: tests/unit/mock/config/compliance/compliance/ruckus_fastiron/fastiron_basic_backup.txt modified: tests/unit/mock/config/compliance/compliance/ruckus_fastiron/fastiron_basic_intended.txt modified: tests/unit/mock/config/compliance/compliance/ruckus_fastiron/fastiron_basic_received.json
pato23arg
requested review from
itdependsnetworks,
jeffkala,
qduk and
abates
as code owners
tests/unit/mock/config/compliance/compliance/ruckus_fastiron/fastiron_basic_backup.txt
Show resolved
Hide resolved
pato23arg
commented
Apr 19, 2023
tests/unit/mock/config/parser/base/ruckus_fastiron/fastiron_full_received.py
Outdated
Show resolved
Hide resolved
jeffkala
requested changes
Apr 19, 2023
| config_line="+----------------+ WARNING RUCKUS SWITCH +---------------+\n.\n. Access to this system is limited to authorized\n. users and for official purposes only\n.\n. Your activities will be logged and abuse\n. will be reported!\n.\n+----------------+ WARNING RUCKUS SWITCH +---------------+$", | ||
| parents=("banner $",), | ||
| ), | ||
| ConfigLine(config_line="+----------------+ WARNING RUCKUS SWITCH +---------------+", parents=()), |
There was a problem hiding this comment.
The seems like a regression, the prior one would be preferred.
This reverts commit a980bb7. modified: netutils/config/parser.py modified: tests/unit/mock/config/parser/base/ruckus_fastiron/fastiron_full_received.py
jeffkala
approved these changes
May 2, 2023
|
Just this should work. And then we could just overload the banner part. class FastironConfigParser(IOSConfigParser):
"""Ruckus FastIron ICX config parser."""
comment_chars: t.List[str] = ["!"]
banner_start: t.List[str] = ["banner motd", "banner"]
regex_banner = re.compile(r"^banner(\smotd)?\s+(?P<banner_delimiter>\S)") |
itdependsnetworks
approved these changes
Jul 1, 2023
jeffkala
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.