Fixs_1009_fortinet_get_system_ha_status.textfsm #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diepes
requested review from
FragmentedPacket,
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
|
Hi @jmcgill298 what can we do to move this along ? |
jmcgill298
requested changes
May 22, 2022
tests/fortinet/get_system_ha_status/fortinet_get_system_ha_status_6.4.raw
Outdated
Show resolved
Hide resolved
guillaume-mbali
pushed a commit
to unyc-io/ntc-templates
that referenced
this pull request
Apr 12, 2023
* Fixs_1009_fortinet_get_system_ha_status.textfsm * Update tests/fortinet/get_system_ha_status/fortinet_get_system_ha_status_6.4.raw Co-authored-by: Pieter E Smit <diepes@github.com> Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
cppmonkey
pushed a commit
to cppmonkey/ntc-templates
that referenced
this pull request
Oct 25, 2023
* Fixs_1009_fortinet_get_system_ha_status.textfsm * Update tests/fortinet/get_system_ha_status/fortinet_get_system_ha_status_6.4.raw Co-authored-by: Pieter E Smit <diepes@github.com> Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
fortinet_get_system_ha_status.textfsm
Tried to make the matching slightly more modular, by matching sections by section.
This did catch some issues where there were matches in unexpected places.
SUMMARY
New Fortinet 6.4 model
Add new raw, and update textfsm
tests/fortinet/get_system_ha_status/fortinet_get_system_ha_status_6.4.raw
tests/fortinet/get_system_ha_status/fortinet_get_system_ha_status_6.4.yml