Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mikrotik routeros ipv6 neighbor print #1146

Conversation

k-ribot
Copy link
Contributor

@k-ribot k-ribot commented May 27, 2022

ISSUE TYPE

New Template Pull Request

COMPONENT

MikroTik, RouterOs, ipv6 neighbor print

SUMMARY

I found examples output in official documentation:
https://wiki.mikrotik.com/wiki/Manual:IPv6/Neighbors

Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, pending tests.

@jvanderaa
Copy link
Contributor

We have some conflicts that have come up.

@k-ribot k-ribot force-pushed the add-mikrotik-routeros-ipv6-neighbor-print branch from becba58 to a806b33 Compare October 3, 2022 15:36
@k-ribot
Copy link
Contributor Author

k-ribot commented Oct 3, 2022

Hi @jvanderaa,

Thank you for your feedbacks.

I have resolved conflits with master.

@k-ribot k-ribot force-pushed the add-mikrotik-routeros-ipv6-neighbor-print branch 2 times, most recently from cd072b4 to a806b33 Compare October 6, 2022 08:48
@k-ribot k-ribot requested review from jvanderaa and removed request for itdependsnetworks, jmcgill298 and FragmentedPacket October 13, 2022 07:20
@k-ribot k-ribot force-pushed the add-mikrotik-routeros-ipv6-neighbor-print branch from a806b33 to b58a696 Compare October 13, 2022 14:23
@k-ribot k-ribot force-pushed the add-mikrotik-routeros-ipv6-neighbor-print branch from b58a696 to da3af03 Compare October 31, 2022 11:07
@k-ribot k-ribot force-pushed the add-mikrotik-routeros-ipv6-neighbor-print branch from da3af03 to c0d7b7a Compare October 31, 2022 12:52
@k-ribot
Copy link
Contributor Author

k-ribot commented Oct 31, 2022

@itdependsnetworks it's a good idea to add empty line management. I added it also in this PR #1145

@jvanderaa jvanderaa merged commit bfe7b01 into networktocode:master Nov 15, 2022
guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
cppmonkey pushed a commit to cppmonkey/ntc-templates that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants