-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Huawei VRP display interface template #1202
Merged
jvanderaa
merged 1 commit into
networktocode:master
from
unyc-io:huawei-vrp-add-display-interface-template
Dec 9, 2022
Merged
Add Huawei VRP display interface template #1202
jvanderaa
merged 1 commit into
networktocode:master
from
unyc-io:huawei-vrp-add-display-interface-template
Dec 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-ribot
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
October 13, 2022 13:34
k-ribot
force-pushed
the
huawei-vrp-add-display-interface-template
branch
3 times, most recently
from
October 24, 2022 14:46
81c7266
to
9ff3030
Compare
jvanderaa
added
status: accepted
This issue has been accepted by the maintainers team for implementation
status: action required
This issue requires additional information to be actionable
labels
Oct 26, 2022
Looks like we may need some conflicts resolved. Able to take a stab at those? |
jvanderaa
requested changes
Oct 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an Error line at the end for error handling.
k-ribot
force-pushed
the
huawei-vrp-add-display-interface-template
branch
from
October 31, 2022 10:56
9ff3030
to
a5b909a
Compare
@jvanderaa I have added Error line |
k-ribot
force-pushed
the
huawei-vrp-add-display-interface-template
branch
from
October 31, 2022 13:04
a5b909a
to
66f3a9f
Compare
k-ribot
requested review from
jvanderaa
and removed request for
itdependsnetworks and
jmcgill298
October 31, 2022 15:51
jvanderaa
requested changes
Oct 31, 2022
k-ribot
force-pushed
the
huawei-vrp-add-display-interface-template
branch
from
October 31, 2022 16:02
66f3a9f
to
7301d8e
Compare
elavaud
force-pushed
the
huawei-vrp-add-display-interface-template
branch
from
November 15, 2022 10:56
7301d8e
to
2c571af
Compare
Added 2 small fixes |
CI failure is due to network unreachable. Needs to be relaunched. |
k-ribot
force-pushed
the
huawei-vrp-add-display-interface-template
branch
from
November 21, 2022 11:27
2c571af
to
275b335
Compare
k-ribot
force-pushed
the
huawei-vrp-add-display-interface-template
branch
from
December 5, 2022 06:58
275b335
to
2fbdd2c
Compare
itdependsnetworks
approved these changes
Dec 5, 2022
jvanderaa
approved these changes
Dec 9, 2022
guillaume-mbali
pushed a commit
to unyc-io/ntc-templates
that referenced
this pull request
Apr 12, 2023
cppmonkey
pushed a commit
to cppmonkey/ntc-templates
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ken-review
status: accepted
This issue has been accepted by the maintainers team for implementation
status: action required
This issue requires additional information to be actionable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
Huawei, VRP, display sn interface
SUMMARY
https://support.huawei.com/enterprise/fr/doc/EDOC1100064353/e51dee46/display-interface