Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Huawei VRP display interface template #1202

Conversation

k-ribot
Copy link
Contributor

@k-ribot k-ribot commented Oct 13, 2022

ISSUE TYPE
  • New Template Pull Request
COMPONENT

Huawei, VRP, display sn interface

SUMMARY

https://support.huawei.com/enterprise/fr/doc/EDOC1100064353/e51dee46/display-interface

@k-ribot k-ribot force-pushed the huawei-vrp-add-display-interface-template branch 3 times, most recently from 81c7266 to 9ff3030 Compare October 24, 2022 14:46
@jvanderaa jvanderaa added status: accepted This issue has been accepted by the maintainers team for implementation status: action required This issue requires additional information to be actionable labels Oct 26, 2022
@jvanderaa
Copy link
Contributor

Looks like we may need some conflicts resolved. Able to take a stab at those?

Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an Error line at the end for error handling.

@k-ribot k-ribot force-pushed the huawei-vrp-add-display-interface-template branch from 9ff3030 to a5b909a Compare October 31, 2022 10:56
@k-ribot
Copy link
Contributor Author

k-ribot commented Oct 31, 2022

@jvanderaa I have added Error line

@k-ribot k-ribot force-pushed the huawei-vrp-add-display-interface-template branch from a5b909a to 66f3a9f Compare October 31, 2022 13:04
@k-ribot k-ribot requested review from jvanderaa and removed request for itdependsnetworks and jmcgill298 October 31, 2022 15:51
@k-ribot k-ribot force-pushed the huawei-vrp-add-display-interface-template branch from 66f3a9f to 7301d8e Compare October 31, 2022 16:02
@elavaud elavaud force-pushed the huawei-vrp-add-display-interface-template branch from 7301d8e to 2c571af Compare November 15, 2022 10:56
@elavaud
Copy link
Contributor

elavaud commented Nov 15, 2022

Added 2 small fixes

@elavaud
Copy link
Contributor

elavaud commented Nov 15, 2022

CI failure is due to network unreachable. Needs to be relaunched.

@k-ribot k-ribot force-pushed the huawei-vrp-add-display-interface-template branch from 2c571af to 275b335 Compare November 21, 2022 11:27
@k-ribot k-ribot force-pushed the huawei-vrp-add-display-interface-template branch from 275b335 to 2fbdd2c Compare December 5, 2022 06:58
@jvanderaa jvanderaa merged commit 8eb554c into networktocode:master Dec 9, 2022
guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
cppmonkey pushed a commit to cppmonkey/ntc-templates that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ken-review status: accepted This issue has been accepted by the maintainers team for implementation status: action required This issue requires additional information to be actionable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants