Fixed TYPE regex to include non-dynamic addresses #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afly007
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
| @@ -1,6 +1,6 @@ | |||
| Value MAC (\S+) | |||
| Value VLAN (\d+) | |||
| Value TYPE ([a-z]+) | |||
| Value TYPE ([a-z-]+) | |||
There was a problem hiding this comment.
Would (\S+) work?
There was a problem hiding this comment.
Yes, changed to (\S+).
|
Can you add to the existing tests to ensure there is no regression in the future? |
itdependsnetworks
approved these changes
Dec 22, 2022
guillaume-mbali
pushed a commit
to unyc-io/ntc-templates
that referenced
this pull request
Apr 12, 2023
* Fixed TYPE regex to include non-dynmaic addresses * Updated TYPE regex to include non-dynmaic addresses * Added tests for port-access-security TYPE regex
cppmonkey
pushed a commit
to cppmonkey/ntc-templates
that referenced
this pull request
Oct 25, 2023
* Fixed TYPE regex to include non-dynmaic addresses * Updated TYPE regex to include non-dynmaic addresses * Added tests for port-access-security TYPE regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a small error with MAC addresses that had type port-access-security. They weren't being processed properly by the regex.
Without the fix parsing would fail on line 5