Release 4.3.0 #1611
Merged
Release 4.3.0 #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanderaa
requested review from
itdependsnetworks and
jmcgill298
as code owners
|
tests/test_structured_data_against_parsed_reference_files.py::test_raw_data_against_mock[tests/fortinet/get_system_status/fortinet_get_system_status_7.0.raw] FAILED [ 42%] |
|
Working to fix the tests. Not sure how the tests started failing when all of them passed to get merged in. |
|
@itdependsnetworks this is now ready. |
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "ntc_templates" | |||
| version = "4.0.1" | |||
| version = "4.3.0" | |||
There was a problem hiding this comment.
How is this changing from 4.0.1 -> 4.3.0?
There was a problem hiding this comment.
That is a great question. The releases on GitHub are lining up, have the appropriate publications to Pypi in the right versions. How the pyproject.toml and GH versions are out of sync is something that I do not have the answer to. Unless maybe something got merged from a 4.0.1 base.
itdependsnetworks
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 4.3.0 Prep.