Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Ciena Saos: Added more use cases to vlan_show #707

Merged
merged 13 commits into from May 20, 2020
Merged

BugFix: Ciena Saos: Added more use cases to vlan_show #707

merged 13 commits into from May 20, 2020

Conversation

FragmentedPacket
Copy link
Contributor

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

ciena_saos_vlan_show.textfsm

SUMMARY

Adds in more use cases from #640

@georgesnow @friday963

The name does change in these, is that OK?

@georgesnow
Copy link
Contributor

Is this change you are referring to:

Value VLAN_NAME ([0-9a-zA-Z_#]+)

Value NAME ([0-9a-zA-Z_#]+)

@FragmentedPacket
Copy link
Contributor Author

Correct. That is a difference between both of y'all templates and is disruptive for you

@georgesnow
Copy link
Contributor

shouldn't effect me. I am not actually using the template for anything. I only added as baseline to basic output of the command.

@FragmentedPacket FragmentedPacket merged commit 3f9b891 into networktocode:master May 20, 2020
@FragmentedPacket FragmentedPacket deleted the fix-ciena-vlan branch May 20, 2020 13:14
@FragmentedPacket
Copy link
Contributor Author

@georgesnow Thanks for the quick response!

@FragmentedPacket FragmentedPacket mentioned this pull request May 20, 2020
thomasblass pushed a commit to thomasblass/ntc-templates that referenced this pull request Oct 25, 2020
guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants