Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Salicru__SLC_1500_TWIN_PRO3__usbhid_ups__2.7.4__01.dev report… #17

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

jimklimov
Copy link
Member

@jimklimov jimklimov commented Jan 10, 2022

…from issue networkupstools/nut#1142

Sanity check list

  • This PR is named to help easy searches (identify the vendor, device...)

  • Data dump file name follows this pattern (safely using ASCII characters):
    <manufacturer>__<model>__<driver-name>__<nut-version>__<report-number>.<extension>
    (more nuances are documented on site).

  • This file is placed into a sub-directory named same as the manufacturer.

  • Information from upsc discovered fields is provided un-commented.

  • Additional data about supported RW variables and instant commands is
    prefixed with standardized comment mark-up as documented on site, e.g.:

#RW:<var.name>:<type>:<options>

and

#CMD:<command.name>
  • Mark-up for structured comments is followed, where applicable.

  • For devices supported only with special settings in their ups.conf
    configuration section (e.g. vendorid and productid required along
    with a USB subdriver), example section content is welcome as a comment.

  • For a newly discovered supported device, a sibling PR for the main
    NUT codebase (at least docs/driver.list.in, or possibly VID/PID and
    other auto-detection mapping tables in the driver sources) is welcome.

  • This PR is linked to relevant issue(s) and/or PRs in the NUT project
    if applicable

@jimklimov jimklimov merged commit c48a2f1 into networkupstools:master Jan 10, 2022
@jimklimov jimklimov deleted the salicru-usb-id branch January 10, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant