Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/apc-mib.c: update MIB values #2264

Merged
merged 2 commits into from Jan 18, 2024

Conversation

moenoel
Copy link

@moenoel moenoel commented Jan 15, 2024

Some of the mapped SNMP values for the APC MIB are incomplete/out of date, most importantly for the OID ".1.3.6.1.4.1.318.1.1.1.4.1.1.0" (upsBasicOutputStatus). This causes NUT to report that it lost connection to a UPS that is e.g. in the "ECOnversion" operation mode, as the corresponding unmapped value results in an empty ups.status.

I updated this and a few other things based on PowerNet MIB v4.5.2 and the SNMP documentation for APC Galaxy VS/PX/VL UPSes.

Some things that probably need to be looked at before this can be merged:

  • I am unsure whether there is a better thing to return than "LB" for the batteryInFaultCondition(4) and noBatteryPresent(5) states. I put "LB" for now as a fail safe way to handle them.
  • I was unable to find documentation for the states powerSavingMode(18), activeLoad(23), chargerOnly(26) and distributedEnergyReserve(27), so I left them empty for now. Seems like they're not inuse for the UPS I'm interested in here, at least.
  • I added a keyword ECO to the return values for ecoMode(13) and eConversion(20). Not sure if that might break anything or be of value to anyone for monitoring purposes and whatnot.

@jimklimov jimklimov added enhancement APC SNMP impacts-release-2.8.1 Issues reported against NUT release 2.8.1 (maybe vanilla or with minor packaging tweaks) labels Jan 15, 2024
@jimklimov
Copy link
Member

Just in case, seems related to #2239 which tackled at least some more OIDs (but in a less efficient fashion, making a separate subdriver).

1.60 is more future-proof than 1.7 (after 1.6) :)
@jimklimov jimklimov added this to the 2.8.2 milestone Jan 18, 2024
@jimklimov jimklimov merged commit 83f7b4e into networkupstools:master Jan 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APC enhancement impacts-release-2.8.1 Issues reported against NUT release 2.8.1 (maybe vanilla or with minor packaging tweaks) SNMP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants