drivers/apc-mib.c: update MIB values#2264
Merged
jimklimov merged 2 commits intonetworkupstools:masterfrom Jan 18, 2024
Merged
Conversation
Member
|
Just in case, seems related to #2239 which tackled at least some more OIDs (but in a less efficient fashion, making a separate subdriver). |
1.60 is more future-proof than 1.7 (after 1.6) :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the mapped SNMP values for the APC MIB are incomplete/out of date, most importantly for the OID ".1.3.6.1.4.1.318.1.1.1.4.1.1.0" (upsBasicOutputStatus). This causes NUT to report that it lost connection to a UPS that is e.g. in the "ECOnversion" operation mode, as the corresponding unmapped value results in an empty
ups.status.I updated this and a few other things based on PowerNet MIB v4.5.2 and the SNMP documentation for APC Galaxy VS/PX/VL UPSes.
Some things that probably need to be looked at before this can be merged:
batteryInFaultCondition(4)andnoBatteryPresent(5)states. I put "LB" for now as a fail safe way to handle them.powerSavingMode(18),activeLoad(23),chargerOnly(26)anddistributedEnergyReserve(27), so I left them empty for now. Seems like they're not inuse for the UPS I'm interested in here, at least.ECOto the return values forecoMode(13)andeConversion(20). Not sure if that might break anything or be of value to anyone for monitoring purposes and whatnot.