Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usbhid-ups: Complete the onlinedischarge_log_throttle_hovercharge option support #2423

Closed
jimklimov opened this issue Apr 27, 2024 · 0 comments · Fixed by #2428
Closed

usbhid-ups: Complete the onlinedischarge_log_throttle_hovercharge option support #2423

jimklimov opened this issue Apr 27, 2024 · 0 comments · Fixed by #2428
Labels
bug impacts-release-2.8.2 Issues reported against NUT release 2.8.2 (maybe vanilla or with minor packaging tweaks) USB
Milestone
2.8.3

Comments

@jimklimov
Copy link
Member

jimklimov commented Apr 27, 2024 •
edited

It seems that during work on #2215 / #2216 something transpired that in currently committed code there is a C and config (string) variable of onlinedischarge_log_throttle_hovercharge and its handling in code, but no actual setting from the string into the number.

Note: do not confuse with the also introduced onlinedischarge_log_throttle_charge which allows to report only changes of the current_charge and not spam on cycles where it remains same as before.
@jimklimov jimklimov added bug USB impacts-release-2.8.2 Issues reported against NUT release 2.8.2 (maybe vanilla or with minor packaging tweaks) labels Apr 27, 2024
@jimklimov jimklimov added this to the 2.8.3 milestone Apr 27, 2024
jimklimov added a commit to jimklimov/nut that referenced this issue May 2, 2024
@jimklimov
drivers/usbhid-ups.c: update messages and comments about onlinedischa…
64dcd87 
…rge_log_throttle_*charge [networkupstools#2215, networkupstools#2423]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
jimklimov added a commit to jimklimov/nut that referenced this issue May 2, 2024
@jimklimov
drivers/usbhid-ups.c, NEWS.adoc: complete the support of onlinedischa…
35bb8eb 
…rge_log_throttle_hovercharge setting [networkupstools#2215, networkupstools#2423]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
@jimklimov jimklimov mentioned this issue May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug impacts-release-2.8.2 Issues reported against NUT release 2.8.2 (maybe vanilla or with minor packaging tweaks) USB
Projects
None yet
Milestone
2.8.3
Development

Successfully merging a pull request may close this issue.

usbhid-ups.c: complete the support of onlinedischarge_log_throttle_hovercharge setting jimklimov/nut
1 participant
@jimklimov