Added socomec_jbus implementation #1313
Conversation
There was a problem hiding this comment.
Thanks for the contribution. Code seems decent, CI would say more. I had a few comments posted for the man page.
Indeed, the "legality" is a concern, although I suppose the wording refers to the product (UPS) being a potentially dangerous high-power 3-phase beast, so it is not to be installed by layman enthusiasts but by certified electricians - and otherwise, no legal fault for Socomec if someone gets fried.
| This driver is not built by default. You can build it by installing libmodbus | ||
| (with development packages) and running | ||
|
|
||
| configure --with-serial=yes --with-modbus=yes |
There was a problem hiding this comment.
./configure
and actually, I think it should be built "by default" as long as libmodbus-dev (or equivalent) is detected:
NUT_ARG_WITH([modbus], [build and install modbus drivers], [auto])
docs/man/socomec_jbus.txt
Outdated
| DB9 connector, so if you construct the cable yourself, use a male DB9 on | ||
| one end. | ||
|
|
||
| It only uses RX,TX and ground, so do not strain too much with DTR et all |
There was a problem hiding this comment.
et al (single L)
also generally revise the text to be less of a casual blog and more documentalistic in style, and trim trailing whitespaces :)
|
Also as a general comment, it is recommended to issue PRs not from a fork's "master" branch but from a separate branch for each feature - makes resync's easier, and parallelization of unrelated improvements from same author too ;) |
|
I've been waiting for a week for response from Socomec regarding the legal status of the document. |
|
I think fixing the text in the same branch and pushing from your computer
to your github fork will suffice to iterate on the existing PR, no need to
make new ones superfluously :)
Jim
|
Added a driver for the modbus-based JBUS protocol over serial RS-232 for Socomec UPS. Obviously a modbus sub-driver.
The documentation was found freely on the net but in there it is stated ``This is a product for restricted sales distribution to informed partners. Installation restrictions or additional measures may be needed to prevent disturbances”.
So the legal status is dubious at best.
It only reads UPS status at the moment and has no support for writing UPS variables or sending commands.
Based mostly on the work done for huawei-ups2000 by Yifeng Li.
Most of the read functions appear to work as expected, though it's only been tested with a DIGYS 3/3 15kVA model.
Tested and working on Linux x86-64 and Raspberry-pi3 ARM.