APC HID UPS: Add ability to set battery battery.mfr.date #1318
Conversation
|
Looks good! I'll be without a computer for a while, so sanity-checking: should that be a |
|
The function prototype has been defined as returning a double, so it
wouldn't really change anything, even if the function did the intermediary
steps with a long, would it? I'm not against making any changes, though, if
you insist: just tell me what you want.
The code does work with my two APC devices just fine, though.
…On 28. helmikuuta 2022 17.07.20 Jim Klimov ***@***.***> wrote:
Looks good!
I'll be without a computer for a while, so sanity-checking: should that be
a double type? Not a long like in snmp-ups for example?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Wanter to say "Okay then" (at least until/unless this is a bug for someone)
- "just sanity-checking so far".
But then I wondered if 32-bit, or ARM/MIPS/... CPU builds would take kindly
to bit shifts in a double. It does actually feel safer to manipulate bits
in a `long` (or better e.g. `uint32_t`) temp var, and cast to `double` for
just the return.
Moving computers, can't test myself :\
…On Mon, Feb 28, 2022, 16:28 WereCatf ***@***.***> wrote:
The function prototype has been defined as returning a double, so it
wouldn't really change anything, even if the function did the intermediary
steps with a long, would it? I'm not against making any changes, though,
if
you insist: just tell me what you want.
The code does work with my two APC devices just fine, though.
On 28. helmikuuta 2022 17.07.20 Jim Klimov ***@***.***> wrote:
>
> Looks good!
> I'll be without a computer for a while, so sanity-checking: should that
be
> a double type? Not a long like in snmp-ups for example?
> —
> Reply to this email directly, view it on GitHub, or unsubscribe.
> Triage notifications on the go with GitHub Mobile for iOS or Android.
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
—
Reply to this email directly, view it on GitHub
<#1318 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMPTFBTTHDL54CNHR3Y2KDU5OICXANCNFSM5PPGOU5Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
@jimklimov You're probably correct: better safe than sorry. I have amended my commit; do let me know, if you want any more changes. |
Some APC UPSes allow for setting battery.mfr.date, so it can be easily referenced later, even if there were no stickers or papers left to refer to. This patch has been tested to work with APC Back-UPS ES 550G. Signed-off-by: Nita Vesa <werecatf@outlook.com>
|
Is there a direct link to a logfile or something somewhere, so I could see what the CI-build failed at? The website never loads for me, no matter what I do. It just stalls and so I can't check what's going on. |
|
Unfortunately the sponsor-provided VMs behind NUT CI are quite weak or overwhelmed since the new-year migration, so it does take a while for Jenkins to render or to think a next thought :( The website does open, at least for the legacy interface (cut the URL at build number) but indeed it can take a minute too. I'll take a look at making legacy UI the default there; the new fancy UI autorefresh kicks in before it renders the thing, it seems. The build page should have links to specific logs of failed scenarios, primarily seek the "*.check.gz" files in the list; the general "console" log is too cluttered to make sense of usually. |
|
If I'm reading that right, it seems the build failed because...the build-process got disconnected? |
|
"There is no cloud, just somebody else's..." (leftover) "...computers" |
Some APC UPSes allow for setting battery.mfr.date, so it can be
easily referenced later, even if there were no stickers or papers
left to refer to.
This patch has been tested to work with APC Back-UPS ES 550G.
Signed-off-by: Nita Vesa werecatf@outlook.com