drivers/mge-hid.c: mge_claim(): test that VendorID==PHOENIXTEC 0x06da… #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… has also Vendor or Product containing "AEG"
jimklimov
added
liebert
MGE
clepple
approved these changes
Apr 9, 2022
jimklimov
added
the
ready / gonna merge
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… has also Vendor or Product containing "AEG"
Follows up from investigation for #564 and #560 that we have a conflict for USB Vendor ID 0x06da in the upshid-ups subdrivers. This PR aims to separate the detection in a way that the mge-hid.c would only claim devices whose Vendor or Product strings contain "AEG", and so allow liebert-hid.c to still support the rest of devices with this chip.
This is an opportunistically proposed "logically meaningful" change as I have no such devices to really test against. Looking at existing code, I think that liebert-hid.c got shadowed after commit a08a229 (in 2016) and all devices with this VID were grabbed by mge-hid.c after NUT 2.7.4.