Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "egrep" by "grep -E" in shell code - modern systems frown upon the former #1660

Merged
merged 2 commits into from Sep 16, 2022
Merged

Replace "egrep" by "grep -E" in shell code - modern systems frown upon the former #1660

merged 2 commits into from Sep 16, 2022

Conversation

jimklimov
Copy link
Member

Coding style primarily. Hoping no OS on horizon is too old to lack grep -E

@jimklimov jimklimov added enhancement refactor/fightwarn PR or issue proposal to improve code maintainability without functional changes, or to fix warnings labels Sep 14, 2022
@jimklimov jimklimov added this to the 2.8.1 milestone Sep 14, 2022
@jimklimov jimklimov merged commit 2003b0d into networkupstools:master Sep 16, 2022
@jimklimov jimklimov deleted the fix-egrep branch September 16, 2022 06:50
@jimklimov jimklimov mentioned this pull request Dec 22, 2022
Closed
@jimklimov
Copy link
Member Author

Note: older systems on the opposite did not have grep -E (at least in default PATH implementation) but had egrep. See #1736 for one such example and workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement refactor/fightwarn PR or issue proposal to improve code maintainability without functional changes, or to fix warnings
Projects
None yet
Milestone
2.8.1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jimklimov