-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid upssched
infinite tight loops with (probably) closed sockets
#1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jun 13, 2023
…bug remains noisy for daemon part too [networkupstools#1965]
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Jun 13, 2023
…/dev/null) when nut_debug_level!=0 (follow-up from [networkupstools#1879, networkupstools#1889])
…y (even if no formal errors are reported) [networkupstools#1964]
…ottle in case we have empty sock_read()s [networkupstools#1964]
…bug remains noisy for daemon part too [networkupstools#1965]
Rebased over master to stay clean, while waiting for reviews... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
ready / code review
Author (and CI) consider the PR worthy of human rewievers' time
upssched
Questions and issues about upssched (timer helper for upsmon)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1964
Probably fallout from #1274 - CC @dtsecon for review
Now it is all quiet (literally, my fans whirred up without the fix):
And that is it, the daemon is holding the clock.
And it has truly exited: