Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more variables from the CyberPower MIB #1982

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Added more variables from the CyberPower MIB #1982

merged 6 commits into from
Aug 14, 2023

Conversation

cholyoak
Copy link
Contributor

@cholyoak cholyoak commented Jul 7, 2023

Added some more fields from the CyberPower MIB (v2.11) including:

  • ups.id
  • ups.status (adding hardware status from CPS-MIB::upsStatus.0)
  • ups.temperature
  • battery.date
  • input.transfer.reason
  • ups.test.date
  • ups.test.result

MAINTAINER NOTE: See also #686 with previous large data point changes

@jimklimov
Copy link
Member

Thanks! Can you please check against docs/nut-names.txt for standard naming to common concepts (and bring up on nut-upsdev mailing list if more need to be introduced)?

The ups.status in particular has a fixed set of values or combinations (OL, OB, CHRG etc.)

@jimklimov
Copy link
Member

Hi, somehow the question in mailing list did not gain traction, however your idea there about putting these status values (overheat, HW fault) into alarms/alerts instead sounds interesting.

While https://github.com/networkupstools/nut/blob/master/docs/new-drivers.txt#L223-L239 defines quite a lot of ups.state field values, they are almost all about power and less so about the device. A few that are on the edge by wording are "The battery needs to be replaced" and "UPS bypass circuit is active -- no battery protection is available"...

The next chapter there about UPS Alarms having a less pre-defined vocabulary, and particularly the example in

| ups.alarm | UPS alarms | OVERHEAT
(literally OVERHEAT as a sample ups.alarm value), suggest that this is a better route to follow.

@cholyoak
Copy link
Contributor Author

cholyoak commented Aug 5, 2023

I've moved the ups.status changes to ups.alarm. Not I haven't used the OVERHEAT value as other drivers seem to use more textual values. Let me know if this is a problem.

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
@jimklimov jimklimov marked this pull request as ready for review August 12, 2023 22:44
@jimklimov
Copy link
Member

Thanks, looks reasonable. I refreshed some maintenance cosmetics, waiting for CI give its verdict just in case... :)

@jimklimov jimklimov added this to the 2.8.1 milestone Aug 12, 2023
@jimklimov jimklimov added the ready / gonna merge The PR is in final cycles leading to merge unless someone logs an objection before we hit the button label Aug 12, 2023
@jimklimov jimklimov merged commit 337b384 into networkupstools:master Aug 14, 2023
42 of 48 checks passed
@cholyoak cholyoak deleted the cyberpower_fix branch August 14, 2023 21:41
alexwbaule pushed a commit to alexwbaule/nut that referenced this pull request Oct 4, 2023
…#1982]

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Alex W Baulé <alexwbaule@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CyberPower (CPS) enhancement ready / gonna merge The PR is in final cycles leading to merge unless someone logs an objection before we hit the button SNMP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants