Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Do not install setup.py #2163

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

gdt
Copy link
Contributor

@gdt gdt commented Nov 9, 2023

The code as is installs the python module's setup.py in the site-packages directory; this is incorrect.

This commit removes setup.py from an automake variable, which resolves the issue. I do not know if it impacts any other kind of module publicaition process. We may need a more complicated fix.

Signed-off-by: Greg Troxel <gdt@lexort.com>
@jimklimov
Copy link
Member

Yeah, thanks, that was probably an overkill, and a long night :)

Can you please check if setup.py.in comes into dist archives?

@gdt
Copy link
Contributor Author

gdt commented Nov 10, 2023

make distcheck resulted in PyNUT.py being installed.
Building the generated tarball in pkgsrc succeeded, with PyNUT.py installed.
Yes, setup.py.in is in the distfile.

@jimklimov
Copy link
Member

Thanks!

@jimklimov jimklimov merged commit 956267d into networkupstools:master Nov 10, 2023
4 of 6 checks passed
@gdt gdt deleted the no-setup branch November 10, 2023 00:42
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request Nov 10, 2023
@jimklimov jimklimov added this to the 2.8.2 milestone Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants