Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort input file list #528

Merged
merged 1 commit into from May 15, 2018
Merged

Sort input file list #528

merged 1 commit into from May 15, 2018

Conversation

bmwiedemann
Copy link
Contributor

so that nut builds in a reproducible way
in spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.

so that nut builds in a reproducible way
in spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.
@clepple clepple added the patch label Feb 21, 2018
@clepple clepple self-assigned this Feb 21, 2018
@bmwiedemann
Copy link
Contributor Author

Can I do something to help get this merged?

@jimklimov
Copy link
Member

Poke more? :)
Looks good to me, though I think the sorting here would be based on LANG or LC_ALL active during a build (not sure if that impacts the ASCII filenames anyhow).

@bmwiedemann
Copy link
Contributor Author

I think that is more a concern for the standalone sort(1) program and less so for the builtin perl/python sort functions.

https://stackoverflow.com/questions/8776807/is-pythons-sort-function-the-same-as-linuxs-sort-with-lc-all-c seems to suggest that it is not using locales by default.

@jimklimov
Copy link
Member

@clepple : was there a particular reason you self-assigned this PR and it got on hold over time, e.g. do you have something in mind to experiment with / make sure of? Or can it indeed be merged?

@aquette
Copy link
Member

aquette commented May 15, 2018

LGTM
as for Charles' self assignment, I probably asked him to take over...

@aquette aquette merged commit d693c42 into networkupstools:master May 15, 2018
@aquette
Copy link
Member

aquette commented May 15, 2018

@bmwiedemann thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants