Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale reference to pngmath #2485

Merged
merged 7 commits into from Jun 26, 2017

Conversation

jarrodmillman
Copy link
Member

Completes fix for #2340 (see commit ffa3e5d).

This could be merged as is, but I noticed more cruft in the conf.py that I am happy to fix and include in the PR. For example, there are still references to the old Trac site. I am not planning to change anything substantial and I suspect nothing I do will be user visible.

Should I include additional Sphinx clean up commits in this PR or would you prefer I create a new PR for that purpose? Either way, I can commit the changes over the weekend.

@dschult
Copy link
Member

dschult commented Jun 24, 2017

Go ahead and put the changes into this PR.
Let's see if we can get conf.py cleaned up.

    WARNING: [autosummary] failed to import u'networkx.algorithms.community.generators.LFR_benchmark_graph': no module named networkx.algorithms.community.generators.LFR_benchmark_graph

The module is named `community_generators` not `generators`.
It isn't necessary to specify this (unless you want to use
a local path or an alternative URL other than the cdnjs
Content Delivery Network.  Also the headcoded URL was retired
in April, 2017 according to
http://docs.mathjax.org/en/latest/start.html.
The project is not using bibtex and it is no longer necessary to use
Sphinx stable branch via GitHub.
@jarrodmillman jarrodmillman changed the title WIP: Remove stale reference to pngmath Remove stale reference to pngmath Jun 25, 2017
@jarrodmillman
Copy link
Member Author

This is ready to merge. I rebased on master and tried to make my commit messages self-explanatory. I was able to build the documentation on my system in a virtualenv. I fixed one import warning, but this mostly removes old cruft.

@dschult dschult merged commit 7010119 into networkx:master Jun 26, 2017
@jarrodmillman jarrodmillman deleted the bugfix-for-issue-2340 branch June 26, 2017 19:45
@dschult dschult added this to the networkx-2.0 milestone Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants