Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In 'from_pandas_adjacency', use column names rather than column order. #3111

Merged
merged 2 commits into from Aug 11, 2018
Merged

In 'from_pandas_adjacency', use column names rather than column order. #3111

merged 2 commits into from Aug 11, 2018

Conversation

komo-fr
Copy link
Contributor

@komo-fr komo-fr commented Aug 4, 2018

Fixes #3105.

@dschult dschult changed the title When using 'from_pandas_adjacency', edges are added focusing on column names rather than the order. Fixes #3105. In 'from_pandas_adjacency', use column names rather than column order. Aug 4, 2018
@dschult
Copy link
Member

dschult commented Aug 4, 2018

Looks good so far. Can you add a test to make sure we know if we break using names later?

@komo-fr
Copy link
Contributor Author

komo-fr commented Aug 11, 2018

@dschult
Thank you for reviewing!
I added test code.

@dschult dschult added this to the networkx-2.2 milestone Aug 11, 2018
@dschult dschult merged commit 4d265a6 into networkx:master Aug 11, 2018
@dschult
Copy link
Member

dschult commented Aug 11, 2018

Thanks! This is very helpful...

@komo-fr komo-fr deleted the fix-for-issue-3105 branch October 2, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: Maintenance
Milestone
networkx-2.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@komo-fr @dschult