Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement Incremental Topological Sort (Issue 1457) #3314

Closed

Conversation

aweltsch
Copy link
Contributor

@aweltsch aweltsch commented Feb 5, 2019

I started to add an algorithm that can be used to incrementally update the topological sorting of a directed graph. I'm not 100% content with the API design. It would be great to get some feedback.

I am particularly concerned with the placement of the corresponding data structure (class IncrementalTopologicalSort). Is the dag.py file the right place?

Also I wondering if I should derive the class from the nx.DiGraph or something like that.

Any additional feedback is greatly appreciated!
Thank you!

@dschult
Copy link
Member

dschult commented Feb 18, 2019

Can you provide a short description of the goal of this feature? What are you trying to achieve relative to the existing algorithms for topological sort (that is -- why create an incremental system)?
The next question is whether you are implementing the published algorithm's data structures as well as program flow. I haven't read it, but your question about whether it should subclass nx.DiGraph might be answered by whether the paper uses a graph-like data structure.

Thanks!

Base automatically changed from master to main March 4, 2021 18:20
@MridulS
Copy link
Member

MridulS commented Nov 8, 2023

Thanks for your work @aweltsch!

This hasn't been touched in a while. I will go ahead and close this for now. Thanks again for your contributions!

@MridulS MridulS closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants