Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphml: re-add graph attribute type 'long' after 857aa81 removed it #4189

Merged
merged 1 commit into from Sep 5, 2020
Merged

graphml: re-add graph attribute type 'long' after 857aa81 removed it #4189

merged 1 commit into from Sep 5, 2020

Conversation

josch
Copy link
Contributor

@josch josch commented Sep 4, 2020

closes: #4188

@jarrodmillman
Copy link
Member

Thanks for this. Would you mind adding a test so that we don't break this again in the future here:
https://github.com/networkx/networkx/blob/master/networkx/readwrite/tests/test_graphml.py

@josch josch force-pushed the master branch 2 times, most recently from 205a3d1 to 9b3d8de Compare September 5, 2020 04:39
@pep8speaks
Copy link

pep8speaks commented Sep 5, 2020 •
edited

Hello @josch! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers!Please install and run psf/black.

Comment last updated at 2020-09-05 04:45:57 UTC

@jarrodmillman jarrodmillman added this to the networkx-2.6 milestone Sep 5, 2020
@jarrodmillman jarrodmillman merged commit 2bfdee6 into networkx:master Sep 5, 2020
@qarawlus qarawlus mentioned this pull request Sep 13, 2020
Merged
MridulS pushed a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
@josch @MridulS
graphml: re-add graph attribute type 'long' after 857aa81 removed it (n…
3ca71c2 
…etworkx#4189)

closes: networkx#4188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschult dschult dschult approved these changes

Assignees
No one assigned
Labels
type: Bug fix
Milestone
networkx-2.6
Development

Successfully merging this pull request may close these issues.

regression: nx 2.5 doesn't support graphml attribute type "long" anymore
4 participants
@josch @jarrodmillman @pep8speaks @dschult