Multiply rooted graph similarity #4907
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschult
reviewed
Jul 29, 2021
| root_u, root_v = roots | ||
| if root_u not in pending_u or root_v not in pending_v: | ||
| raise nx.NodeNotFound("Root node not in graph.") | ||
| roots = [roots] if type(roots) == tuple else roots |
There was a problem hiding this comment.
Suggested change
| roots = [roots] if type(roots) == tuple else roots | |
| if isinstance(roots, tuple) and len(roots) == 2: | |
| roots = [roots] |
dschult
reviewed
Jul 29, 2021
Comment on lines
+1104
to
+1105
| initial_cost = sum( | ||
| [1 - node_match(G1.nodes[root_u], G2.nodes[root_v]) for root_u, root_v in roots]) |
There was a problem hiding this comment.
Should this be (1 - sum(node_match for all pairs of root nodes)) or sum( 1 - nodematch)??
dschult
reviewed
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for multiple roots in all similarity algorithms.
optimize_edit_pathsandgraph_edit_distancehad support for a single root, I've extended the functionality to support multiple roots (multiply vertex-rooted graphs)optimize_graph_edit_distanceandoptimal_edit_pathsactually useoptimize_edit_pathsto search for results but didn't have support for roots, I've added it to those methods as well.