Remove mentioning of gdal #4984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't seem to be used anywhere now. Also 2.5's changelog says it was removed.
|
In 2.5, I removed gdal from the requirements file (see 5638e1ff). These instructions tell you how to install gdal manually. In 2.6, we deprecated gdal. But our support for it will not be removed until the 3.0 release. So this shouldn't be merged until after we remove the use of gdal before the 3.0 release and after the 2.7 release. |
|
It is used here: networkx/readwrite/nx_shp.py. |
|
Ah I see. Thanks for the info! |
|
Thanks for this PR! We are planning to release 2.7 in a couple of months and 3.0 near the end of the year. We will merge this after 2.7 and before 3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't seem to be used anywhere now. Also 2.5's changelog says it was removed.