New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed an error in the documentation of the katz centrality #6294
Conversation
There is another typo in a comment on line 172: It has the formula as "-" Beta when the code clearly uses "+". Thanks for this! |
@BrunoBaldissera are you done with this issue? |
For In the limit case, for |
Excellent @vigna Maybe something like: For strongly connected graphs, as |
OK, I just read the definition and actually it's a bit weird but the original statement was correct. If What is true is when BTW, Said that, I've always seen Katz centrality defined as |
Yes, this is correct for every |
Can this be merged? |
It can be merged once it is clear what the good resolution of the issue is. Can you suggest some wording for the docs to make this all clear? The discussion above makes me believe that the change to the documentation should not be |
Oops. I didn't even realize this is not my branch. I guess I should fork from this branch or something like that? |
You could load the branch by making a git "remote" to it, but you still couldn't push to it. You could make a PR to the PR-branch, but that still relies on the original author responding. Another approach would be to pull the branch from a git remote and then add some commits, push it to your fork of networkx and make a new PR. But maybe that's more than needed. How complex are the changes you are thinking about? Can you make a suggestion in the comments? |
3122117
to
8da1d32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for taking so long to get to this documentation change.
I think it is all ready to merge.
…6294) * fixed a sentence in the documentation relating the parameter beta and the eigenvector centrality * choose ev-cent docs wording, fix formula, remove comment --------- Co-authored-by: Dan Schult <dschult@colgate.edu>
Issue #6279 reported a sentence in the documentation of the method stating
I replaced$\beta=0$ with $\beta=1$ , according to the issue's suggestion (and fixed a small typo along the way).